Bug 403426

Summary:	CSD active and inactive windows are indistinguishable
Product:	[Plasma] Breeze	Reporter:	Yan <yanp.bugz>
Component:	gtk theme	Assignee:	scionicspectre
Status:	RESOLVED FIXED
Severity:	major	CC:	bugseforuns, hugo.pereira.da.costa, kde-bugzilla, kde, nate
Priority:	HI
Version:	5.14.5
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/breeze-gtk/df538d1492948eaf4b2239d6eef63041d59d2772	Version Fixed In:	5.16.0
Sentry Crash Report:

Description Yan 2019-01-20 11:15:27 UTC

SUMMARY

I use two displays. Since kde 5.13 chrome and GTK-CSD apps window headers have become white with black buttons. Colors of header of buttons doesn't change if the window is active or inactive, that confuses frequently.

Comment 1 David Edmundson 2019-03-01 00:57:37 UTC

Does this happen with the adwaita GTK theme?

Comment 2 David Edmundson 2019-03-01 01:20:22 UTC

Adwaita does not change. Seems likely this is an upstream bug. I've got a git gtk checkout, I'll add some debug and find out.

Comment 3 David Edmundson 2019-03-01 02:13:07 UTC

So we have two bugs.

breeze-gtk doesn't do the right thing with the colors:
WIP patch: https://phabricator.kde.org/P338

Works on wayland \o/


On X11, gtk isn't selecting the backdrop class. Probably because kwin doesn't support one of their new activation flags which would be a GTK bug for not following their fallback correctly.

Comment 4 Nate Graham 2019-03-02 13:53:35 UTC

*** Bug 404921 has been marked as a duplicate of this bug. ***

Comment 5 David Edmundson 2019-05-10 15:20:39 UTC

Git commit df538d1492948eaf4b2239d6eef63041d59d2772 by David Edmundson.
Committed on 07/04/2019 at 17:40.
Pushed by davidedmundson into branch 'master'.

Fix colours of header bar for acitve and inactive windows

Summary:
Use and generate correct colours from the window manager palette rather
than the window palette in the headerbar.

This works beautifully on wayland, on X11 kwin doesn't send
NET_WM_STATE_FOCUSSED and GTK doesn't correctly WMs that don't support
it.

Might be worth not committing this till then.

Test Plan: Ran gtk3-demo which requests CSDs

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D19603

M  +3    -3    src/_functions.scss
M  +2    -1    src/gtk320/widgets/_headerbar.scss
M  +4    -7    src/render_assets.py

https://commits.kde.org/breeze-gtk/df538d1492948eaf4b2239d6eef63041d59d2772