| Summary: | Previewing multiple wallpapers is slow | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Gastón Haro <harogaston> |
| Component: | Image Wallpaper | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns, kde, mglb, nate, neilpadgett452, plasma-bugs, qydwhotmail |
| Priority: | NOR | Keywords: | usability |
| Version: | master | Flags: | kde:
Usability+
|
| Target Milestone: | 1.0 | ||
| Platform: | unspecified | ||
| OS: | All | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=398303 | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/18069a0f4a002830b7f66224ffdb17077346c2ee | Version Fixed In: | 5.26 |
| Sentry Crash Report: | |||
|
Description
Gastón Haro
2019-01-19 02:12:30 UTC
This is basically a side effect of not using the instant-apply model. We're the only ones left with OK/Cancel/Apply buttons. One possible improvement might be if we implement Bug 398303. I can do with OK/Cancel/Apply buttons. What I would like is that selecting a wallpaper would "soft apply it" but if you close or cancel the dialog then the selection is reverted and only if you click Apply/OK the selection persists. >I can do with OK/Cancel/Apply buttons.
Glad to hear it, I would be against instant apply, but this we can find some sort of compromise.
The challenge with soft-apply is the communication aspect of what hitting cancel will do.
Maybe that could be solved with a dialog on cancel:
"you have unsaved changes [apply | cancel]"
Maybe we should temporarily apply the wallpaper when simply hovering over its delegate? Then you could move the mouse to quickly preview a bunch of wallpapers. How would we include the "Positioning" combo box? Yeah, feels like we're fighting the system with that idea. Since moving to instant-apply is not likely to happen any time soon, I think implementing Bug 398303 might be our best bet. I actually had this exact use case in mind when I opened that feature request. That idea also wouldn't help with the positioning combo. I think it might, actually: 1. Change item in positioning combobox 2. Double-click on a new image Result: new image is applied to the desktop with the positioning specified in the positioning combobox. I think it's more likely a user would change the positioning / background colour to match the image you've just chosen than before. Could be. This is just a hard problem to solve without implementing Instant Apply for the whole KCM or making the combobox and wallpaper chooser *visibly* apply their settings, but not *actually* apply them (which seems kinda weird). For example implementation see Konsole - it uses live preview & manual apply in Edit profile → Appearance dialog. Double click to apply wallpaper: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1774 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1785 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/969 Git commit 15110e1d2dde2fd48f57875a0fd198d7bb5ad6e0 by Nate Graham, on behalf of Fushan Wen. Committed on 02/06/2022 at 18:51. Pushed by ngraham into branch 'master'. desktoppackage: warn on cancel if there are unsaved settings When single click to preview wallpaper is enabled, it has the potential of confusing users. When they click on the image they might think the image is already applied and just close the window without hitting "apply". This could be solved if a window popped up asking users to apply if they try to close the window before applying, just like System Settings does. M +15 -3 desktoppackage/contents/configuration/AppletConfiguration.qml https://invent.kde.org/plasma/plasma-desktop/commit/15110e1d2dde2fd48f57875a0fd198d7bb5ad6e0 Git commit 18069a0f4a002830b7f66224ffdb17077346c2ee by Nate Graham, on behalf of Fushan Wen. Committed on 02/06/2022 at 18:52. Pushed by ngraham into branch 'master'. wallpapers/image: click image to preview FIXED-IN: 5.26 M +4 -0 wallpapers/image/imagepackage/contents/config/main.xml M +1 -0 wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml M +4 -0 wallpapers/image/imagepackage/contents/ui/config.qml M +11 -1 wallpapers/image/imagepackage/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/commit/18069a0f4a002830b7f66224ffdb17077346c2ee *** Bug 455493 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1006 Git commit 6bfef995d37e61b0e891f6eb4c8406b93c912e1b by Nate Graham, on behalf of Fushan Wen. Committed on 29/06/2022 at 03:09. Pushed by ngraham into branch 'master'. desktoppackage: warn on close if there are unsaved settings M +19 -6 desktoppackage/contents/configuration/AppletConfiguration.qml https://invent.kde.org/plasma/plasma-desktop/commit/6bfef995d37e61b0e891f6eb4c8406b93c912e1b |