Bug 403367

Summary:	Can not compile plasma-desktop 5.14.90 (also I could not find an entry called plasma-desktop so I filed this here)
Product:	[Plasma] plasmashell	Reporter:	shevegen <shevegen>
Component:	Containment	Assignee:	Sebastian Kügler <sebas>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde, nate, plasma-bugs-null
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description shevegen 2019-01-18 17:05:04 UTC

Linux system.

GCC is: g++ (GCC) 8.2.0

I used this URL:

http://download.kde.org/unstable/plasma/5.14.90/plasma-desktop-5.14.90.tar.xz

The compilation stops at about 41%:

[ 41%] Built target org.kde.plasma.kickoff-plasmoids-metadata-json
Scanning dependencies of target org.kde.plasma.trash-plasmoids-metadata-json
[ 41%] Generating org.kde.plasma.trash-plasmoids-metadata.json
About to parse service type file "/usr/share/kservicetypes5/plasma-applet.desktop"
Found property definition "X-Plasma-API" with type "QString" 
Found property definition "X-Plasma-RootPath" with type "QString"  
Found property definition "X-Plasma-MainScript" with type "QString"
Found property definition "X-Plasma-ContainmentType" with type "QString" 
Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"  
Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"
Found property definition "X-Plasma-NotificationArea" with type "QString"
Found property definition "X-Plasma-NotificationAreaCategory" with type "QString" 
Found property definition "X-Plasma-DBusActivationService" with type "QString" 
Found property definition "X-KDE-ParentApp" with type "QString" 
Found property definition "X-Plasma-Provides" with type "QStringList" 
Found property definition "X-Plasma-PreloadWeight" with type "int" 
Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"  
Found property definition "X-Plasma-StandAloneApp" with type "bool"
Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"
Found property definition "NoDisplay" with type "bool" 
Generated  "/Depot/Temp/rbt/plasma-desktop-5.14.90/BUILD_DIRECTORY/applets/trash/org.kde.plasma.trash-plasmoids-metadata.json" 

[ 41%] Built target org.kde.plasma.trash-plasmoids-metadata-json
Scanning dependencies of target trashplugin_autogen
[ 41%] Automatic MOC for target trashplugin
[ 41%] Built target trashplugin_autogen
Scanning dependencies of target trashplugin
[ 41%] Building CXX object applets/trash/plugin/CMakeFiles/trashplugin.dir/dirmodel.cpp.o
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/trash/plugin/dirmodel.cpp: In member function 'virtual QVariant DirModel::data(const QModelIndex&, int) const':
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/trash/plugin/dirmodel.cpp:156:98: warning: this statement may fall through [-Wimplicit-fallthrough=]  
const_cast<DirModel *>(this)->m_filesToPreview[item.url()] = QPersistentModelIndex(index); 
  ^ 
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/trash/plugin/dirmodel.cpp:158:5: note: here 
  default:
  ^~~~~~~ 
[ 41%] Building CXX object applets/trash/plugin/CMakeFiles/trashplugin.dir/trash.cpp.o
[ 41%] Building CXX object applets/trash/plugin/CMakeFiles/trashplugin.dir/trashplugin.cpp.o
[ 41%] Building CXX object applets/trash/plugin/CMakeFiles/trashplugin.dir/trashplugin_autogen/mocs_compilation.cpp.o
[ 41%] Linking CXX shared library ../../../bin/libtrashplugin.so
[ 41%] Built target trashplugin
Scanning dependencies of target taskmanagerplugin_autogen
[ 42%] Automatic MOC for target taskmanagerplugin
[ 42%] Built target taskmanagerplugin_autogen
Scanning dependencies of target taskmanagerplugin
[ 42%] Building CXX object applets/taskmanager/CMakeFiles/taskmanagerplugin.dir/plugin/backend.cpp.o
[ 42%] Building CXX object applets/taskmanager/CMakeFiles/taskmanagerplugin.dir/plugin/draghelper.cpp.o
[ 42%] Building CXX object applets/taskmanager/CMakeFiles/taskmanagerplugin.dir/plugin/taskmanagerplugin.cpp.o
[ 42%] Building CXX object applets/taskmanager/CMakeFiles/taskmanagerplugin.dir/plugin/smartlaunchers/smartlauncherbackend.cpp.o
[ 42%] Building CXX object applets/taskmanager/CMakeFiles/taskmanagerplugin.dir/plugin/smartlaunchers/smartlauncheritem.cpp.o
[ 42%] Building CXX object applets/taskmanager/CMakeFiles/taskmanagerplugin.dir/taskmanagerplugin_autogen/mocs_compilation.cpp.o
[ 42%] Linking CXX shared library ../../bin/libtaskmanagerplugin.so
[ 42%] Built target taskmanagerplugin
Scanning dependencies of target org.kde.plasma.taskmanager-plasmoids-metadata-json
[ 42%] Generating org.kde.plasma.taskmanager-plasmoids-metadata.json
About to parse service type file "/usr/share/kservicetypes5/plasma-applet.desktop"
Found property definition "X-Plasma-API" with type "QString" 
Found property definition "X-Plasma-RootPath" with type "QString"  
Found property definition "X-Plasma-MainScript" with type "QString"
Found property definition "X-Plasma-ContainmentType" with type "QString" 
Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"  
Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"
Found property definition "X-Plasma-NotificationArea" with type "QString"
Found property definition "X-Plasma-NotificationAreaCategory" with type "QString" 
Found property definition "X-Plasma-DBusActivationService" with type "QString" 
Found property definition "X-KDE-ParentApp" with type "QString" 
Found property definition "X-Plasma-Provides" with type "QStringList" 
Found property definition "X-Plasma-PreloadWeight" with type "int" 
Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"  
Found property definition "X-Plasma-StandAloneApp" with type "bool"
Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"
Found property definition "NoDisplay" with type "bool" 
Generated  "/Depot/Temp/rbt/plasma-desktop-5.14.90/BUILD_DIRECTORY/applets/taskmanager/org.kde.plasma.taskmanager-plasmoids-metadata.json"  

[ 42%] Built target org.kde.plasma.taskmanager-plasmoids-metadata-json
Scanning dependencies of target pagerplugin_autogen
[ 42%] Automatic MOC for target pagerplugin
[ 42%] Built target pagerplugin_autogen
Scanning dependencies of target pagerplugin
[ 42%] Building CXX object applets/pager/CMakeFiles/pagerplugin.dir/plugin/pagermodel.cpp.o
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp: In member function 'int PagerModel::currentPage() const':
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:363:39: error: 'class TaskManager::VirtualDesktopInfo' has no member named 'desktopIds'; did you mean 'desktopNames'?  
return d->virtualDesktopInfo->desktopIds().indexOf(d->virtualDesktopInfo->currentDesktop());  
^~~~~~~~~~
desktopNames 
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp: In member function 'void PagerModel::refresh()':
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:434:67: error: 'class TaskManager::VirtualDesktopInfo' has no member named 'desktopIds'; did you mean 'desktopNames'?  
 windowModel->setVirtualDesktop(d->virtualDesktopInfo->desktopIds().at(virtualDesktop));
 ^~~~~~~~~~  
 desktopNames
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:444:44: error: no matching function for call to 'WindowModel::setVirtualDesktop()' 
 windowModel->setVirtualDesktop();
  ^ 
In file included from /Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/windowmodel.h:23, 
  from /Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:23:
/usr/include/taskmanager/taskfilterproxymodel.h:87:10: note: candidate: 'void TaskManager::TaskFilterProxyModel::setVirtualDesktop(uint)'
  void setVirtualDesktop(uint virtualDesktop);
 ^~~~~~~~~~~~~~~~~ 
/usr/include/taskmanager/taskfilterproxymodel.h:87:10: note:candidate expects 1 argument, 0 provided
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp: In member function 'void PagerModel::moveWindow(int, double, double, const QVariant&, const QVariant&, qreal, qreal)':
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:538:88: error: 'WinIdList' is not a member of 'TaskManager::AbstractTasksModel' 
  const QVariantList &winIds = idx.data(TaskManager::AbstractTasksModel::WinIdList).toList(); 
 ^~~~~~~~~
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:540:64: warning: comparison of integer expressions of different signedness: 'uint' {aka 'unsigned int'} and 'int' [-Wsign-compare] 
  if (!winIds.isEmpty() && winIds.at(0).toUInt() == window) {
~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:541:33: error: 'class TaskManager::WindowTasksModel' has no member named 'requestVirtualDesktops'; did you mean 'requestVirtualDesktop'? 
tasksModel->requestVirtualDesktops(idx, QVariantList() << targetItemId.toString());  
^~~~~~~~~~~~~~~~~~~~~~
requestVirtualDesktop 
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp: In member function 'void PagerModel::changePage(int)':
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:562:36: error: 'class TaskManager::VirtualDesktopInfo' has no member named 'requestActivate'
 d->virtualDesktopInfo->requestActivate(d->virtualDesktopInfo->desktopIds().at(page));  
^~~~~~~~~~~~~~~ 
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:562:75: error: 'class TaskManager::VirtualDesktopInfo' has no member named 'desktopIds'; did you mean 'desktopNames'?  
 d->virtualDesktopInfo->requestActivate(d->virtualDesktopInfo->desktopIds().at(page));  
^~~~~~~~~~
desktopNames 
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp: In member function 'void PagerModel::drop(QMimeData*, const QVariant&)':
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:621:69: error: 'winIdsFromMimeData' is not a member of 'TaskManager::WaylandTasksModel'
const QList<quint32> &ids = TaskManager::WaylandTasksModel::winIdsFromMimeData(mimeData, &ok);
^~~~~~~~~~~~~~~~~~
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:639:92: error: 'WinIdList' is not a member of 'TaskManager::AbstractTasksModel'
const QVariantList &winIds = idx.data(TaskManager::AbstractTasksModel::WinIdList).toList();
  ^~~~~~~~~
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:642:37: error: 'class TaskManager::WindowTasksModel' has no member named 'requestVirtualDesktops'; did you mean 'requestVirtualDesktop'?
 tasksModel->requestVirtualDesktops(idx, QVariantList() << itemId.toString());
 ^~~~~~~~~~~~~~~~~~~~~~
 requestVirtualDesktop
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp: In member function 'void PagerModel::addDesktop()':
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:653:28: error: 'class TaskManager::VirtualDesktopInfo' has no member named 'requestCreateDesktop'; did you mean 'currentDesktop'?
  d->virtualDesktopInfo->requestCreateDesktop(d->virtualDesktopInfo->numberOfDesktops());
 ^~~~~~~~~~~~~~~~~~~~
 currentDesktop
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp: In member function 'void PagerModel::removeDesktop()':
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:662:28: error: 'class TaskManager::VirtualDesktopInfo' has no member named 'requestRemoveDesktop'
  d->virtualDesktopInfo->requestRemoveDesktop(d->virtualDesktopInfo->numberOfDesktops() - 1);
 ^~~~~~~~~~~~~~~~~~~~
make[2]: *** [applets/pager/CMakeFiles/pagerplugin.dir/build.make:63: applets/pager/CMakeFiles/pagerplugin.dir/plugin/pagermodel.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:15904: applets/pager/CMakeFiles/pagerplugin.dir/all] Error 2
make: *** [Makefile:141: all] Error 2


Not sure which is the main error but it stopped after:

/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp: In member function 'void PagerModel::removeDesktop()':
/Depot/Temp/rbt/plasma-desktop-5.14.90/applets/pager/plugin/pagermodel.cpp:662:28: error: 'class TaskManager::VirtualDesktopInfo' has no member named 'requestRemoveDesktop'
  d->virtualDesktopInfo->requestRemoveDesktop(d->virtualDesktopInfo->numberOfDesktops() - 1);

Most other unstable plasma-components have compiled fine.

Comment 1 David Edmundson 2019-01-18 19:42:49 UTC

Is plasma-workspace up to date on 5.14.90?

Comment 2 David Edmundson 2019-01-20 15:59:58 UTC

Git commit 270c67514052f06ccb2f196d0d3185423e6b5736 by David Edmundson.
Committed on 20/01/2019 at 15:59.
Pushed by davidedmundson into branch 'Plasma/5.15'.

Set libkworkspace minimum version

Summary: CCBUG: 403367

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18370

M  +3    -3    CMakeLists.txt

https://commits.kde.org/plasma-desktop/270c67514052f06ccb2f196d0d3185423e6b5736

Comment 3 Christoph Feck 2019-02-15 17:11:09 UTC

If above commit did not fix it, please add a comment or re-open the ticket.