Bug 403350

Summary:	After rotating video, when changing video date time, rotation flag is reset
Product:	[Applications] digikam	Reporter:	Jens <jens-bugs.kde.org>
Component:	Metadata-Video	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version First Reported In:	6.0.0
Target Milestone:	---
Platform:	Appimage
OS:	Linux
Latest Commit:	https://commits.kde.org/digikam/420e168f40affd82bd45c27dbbf1c55db98489ac	Version Fixed/Implemented In:	6.0.0
Sentry Crash Report:

Description Jens 2019-01-18 10:38:50 UTC

1. Rotate a video (Ctrl-Shift-Left/right) - THANK YOU this finally works!
2. Change the video's timestamp (not with BQM, but with the separate tool)

Expected: Rotation flag (and all other attributes) should be kept
Actual: Rotation is reset, thumbnail is updated

Comment 1 Maik Qualmann 2019-01-18 20:38:41 UTC

Not really a bug. You have activated the option "Rescan file when files are modified". This will read in the existing (or not) rotation flag again. Either disable this option or do not enable the file modification date checkbox in the Time Adjust Tool.

Maik

Comment 2 Jens 2019-01-18 22:09:03 UTC

I understand, but it is still a bug since it violates the principle of least surprise for the user. 
https://en.wikipedia.org/wiki/Principle_of_least_astonishment

To a user, a connection between mtime and properties is not apparent and should not exist. The mtime is simply another property of the image. So changing the mtime should not have an effect on any other properties.

Comment 3 Maik Qualmann 2019-01-18 22:22:46 UTC

Right and therefore the option "Rescan files when files are modified" must be disabled (this is the default). The Rescan would also reset other properties (color label, rating, etc.). This option is only for users who want external changes to the images to be read completely again. We have to compromise.

Maik

Comment 4 Maik Qualmann 2019-01-20 07:30:38 UTC

Did you enabled the option to write in sidecar?

Maik

Comment 5 Jens 2019-01-20 08:30:18 UTC

Yes, and only in Sidecar files. Originals are not modified.

Comment 6 Maik Qualmann 2019-01-20 10:44:07 UTC

Git commit 420e168f40affd82bd45c27dbbf1c55db98489ac by Maik Qualmann.
Committed on 20/01/2019 at 10:43.
Pushed by mqualmann into branch 'master'.

use the same modification time for the sidecar as the image
FIXED-IN: 6.0.0

M  +2    -2    NEWS
M  +22   -4    core/utilities/timeadjust/timeadjusttask.cpp

https://commits.kde.org/digikam/420e168f40affd82bd45c27dbbf1c55db98489ac

Comment 7 Jens 2019-01-20 14:40:44 UTC

Good point. Thank you!