Bug 403234

Summary:	Editor window does not preserve settings
Product:	[Applications] lokalize	Reporter:	Freek de Kruijf <freekdekruijf>
Component:	editor	Assignee:	Simon Depiets <sdepiets>
Status:	RESOLVED FIXED
Severity:	major	CC:	shafff
Priority:	NOR
Version First Reported In:	2.0
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	https://commits.kde.org/lokalize/cde1083d0cfbb75bdbbed14173758a29fbaf45f5	Version Fixed/Implemented In:
Sentry Crash Report:

Description Freek de Kruijf 2019-01-15 13:07:15 UTC

SUMMARY
Each time I start a new lokalize session and start editing a .po file the layout of the edit window is not preserved compared to an earlier session.

STEPS TO REPRODUCE
1. Start a new session and and edit a .po file and change the layout of the window. Add the Alternative translations sub window and adjust the size of the sub windows where this sub window exists.
2. Exit lokalize and start a new session
3. Start again to edit a .po file. To get the previous layout, one needs to repeat the above actions.

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma:
(available in About System)
KDE Plasma Version: 18.12.0
KDE Frameworks Version: 5.53.0
Qt Version: 5.12.0

ADDITIONAL INFORMATION

Comment 1 Simon Depiets 2019-01-24 09:22:50 UTC

Git commit 159e18479836d342c9a05b194215a4096cdd0724 by Simon Depiets.
Committed on 24/01/2019 at 09:17.
Pushed by sdepiets into branch 'master'.

Improve DockWidgets saving and restoring

The widgets positions were saved only at project level.
- Added a DefaultDockWidget at global level
- Fixed a couple of issues where LastLayout would not be loaded correctly (because overridden in slotSubWindow before being set up in fileOpen)

M  +28   -9    src/lokalizemainwindow.cpp

https://commits.kde.org/lokalize/159e18479836d342c9a05b194215a4096cdd0724

Comment 2 Simon Depiets 2019-01-24 09:28:15 UTC

I've made a couple fixes, I had some awkwards scenariis where it didn't work (for instance closing tab, then closing file, then closing lokalize). A couple of issues where the lastLayout was not loaded correctly at file open because it was overridden by the default layout on the "tabChange" event.

I also added a Global Default DockWidget.

Please let me know your exact scenario if this still fails.

Comment 3 Freek de Kruijf 2019-01-25 10:26:26 UTC

(In reply to Simon Depiets from comment #2)
> Please let me know your exact scenario if this still fails.

I have to wait for an update of lokalize in openSUSE Tumbleweed.
Did you change the version from 2.0 to something like 2.0.1?
The packet version on openSUSE Tumbleweed is 18.12.0-1.1.
The current build for openSUSE factory takes lokalize-18.12.1.tar.xz from some server of kde.org. The .spec file used by openSUSE factory is 14 days old.

Comment 4 Simon Depiets 2019-01-29 16:24:05 UTC

Git commit cde1083d0cfbb75bdbbed14173758a29fbaf45f5 by Simon Depiets.
Committed on 29/01/2019 at 16:38.
Pushed by sdepiets into branch 'Applications/18.12'.

Improve DockWidgets saving and restoring

The widgets positions were saved only at project level.
- Added a DefaultDockWidget at global level
- Fixed a couple of issues where LastLayout would not be loaded correctly (because overridden in slotSubWindow before being set up in fileOpen)

M  +28   -9    src/lokalizemainwindow.cpp

https://commits.kde.org/lokalize/cde1083d0cfbb75bdbbed14173758a29fbaf45f5