Bug 403175

Summary: Clazy fails to build with llvm 7.0.1 on macOS
Product: [Developer tools] clazy Reporter: Yurii Kolesnykov <yurii.kolesnykov>
Component: generalAssignee: Unassigned bugs mailing-list <unassigned-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: smartins, yurii.kolesnykov
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Homebrew (macOS)   
OS: macOS   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Yurii Kolesnykov 2019-01-13 14:02:52 UTC
SUMMARY


STEPS TO REPRODUCE
1. Try to build clazy with llvm 7.0.1 on macOS.

OBSERVED RESULT
ast 15 lines from /Users/yurikoles/Library/Logs/Homebrew/clazy/02.make:
/tmp/clazy-20190113-89841-9h78td/clazy-1.2/src/checks/level2/oldstyleconnect.cpp:390:60: error: no member named 'first' in 'clang::CharSourceRange'
            SourceRange range = SourceRange(expansionRange.first, expansionRange.second);
                                            ~~~~~~~~~~~~~~ ^
/tmp/clazy-20190113-89841-9h78td/clazy-1.2/src/checks/level2/oldstyleconnect.cpp:390:82: error: no member named 'second' in 'clang::CharSourceRange'; did you mean 'setEnd'?
            SourceRange range = SourceRange(expansionRange.first, expansionRange.second);
                                                                                 ^~~~~~
                                                                                 setEnd
/usr/local/Cellar/llvm/7.0.1/include/clang/Basic/SourceLocation.h:267:8: note: 'setEnd' declared here
  void setEnd(SourceLocation e) { Range.setEnd(e); }
       ^
4 errors generated.
make[2]: *** [CMakeFiles/ClangLazy.dir/src/checks/level2/oldstyleconnect.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/ClangLazy.dir/all] Error 2
make: *** [all] Error 2

EXPECTED RESULT
Builds fine.

SOFTWARE/OS VERSIONS
MacOS: 10.14.3
KDE Frameworks Version: 5.54
Qt Version: 5.12

ADDITIONAL INFORMATION
Full log is here: https://gist.github.com/23b6c633b24303a067cd1961fdb32d69
Comment 1 Yurii Kolesnykov 2019-01-13 18:11:57 UTC
Fixed in 1.4