Summary: | No visible indication of active tab in Chromium using dark GTK3 theme | ||
---|---|---|---|
Product: | [Plasma] Breeze | Reporter: | foss |
Component: | gtk theme | Assignee: | scionicspectre |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, nate, sh200105 |
Priority: | HI | Keywords: | usability |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/breeze-gtk/80bcaaf483daea6434bcf2100b3b40bd1b36e4a8 | Version Fixed In: | 5.17.0 |
Sentry Crash Report: | |||
Attachments: |
Screenshot: Guess which is the active tab
Chromium vs Firefox Chromium on different color schemes |
Created attachment 117476 [details]
Chromium vs Firefox
Hmm, you're right. However I notice that Firefox looks good. See attachment.
I'm not sure if this is Chromium's fault for using the wrong identifiers for its UI elements, or Breeze-GTK's fault for assigning those identifiers the wrong colors.
Alexander, any ideas? Created attachment 117483 [details]
Chromium on different color schemes
I just did some experimenting to see how Chromium looks on other GTK themes. I used Breeze in different variants (also with a custom color scheme which uses different colors for different elements), also tried Numix and Adwaita.
It seems that breeze theme takes the same color for the background and tabs, despite of the color scheme used.
This persists in 5.17 with our fancy new color changing stuff. Git commit 80bcaaf483daea6434bcf2100b3b40bd1b36e4a8 by Carson Black. Committed on 13/08/2019 at 14:51. Pushed by cblack into branch 'master'. [GTK3 -> Chrome/ium] Tweak tab stylings Summary: Tabs have had their colors changed to make it easier to tell which is active. Test Plan: Breeze Normal: {F7236514} Breeze Dark: {F7236532} Breeze Light: {F7236540} Reviewers: #breeze, #vdg, ngraham, GB_2 Reviewed By: #breeze, #vdg, ngraham, GB_2 Subscribers: davidre, broulik, ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D23080 A +23 -0 src/gtk3/applications/_chromium.scss M +2 -0 src/gtk3/gtk.scss https://commits.kde.org/breeze-gtk/80bcaaf483daea6434bcf2100b3b40bd1b36e4a8 |
Created attachment 117406 [details] Screenshot: Guess which is the active tab SUMMARY Breeze-dark style and icons are really fantastic, so is the integration of gtk apps in plasma desktop. Am just having a "small" problem with chromium Browser that I sometimes accidentally close/select/click the wrong tab. Hopefully this gets an end and makes the integration and visual style even better. STEPS TO REPRODUCE 1. Set breeze-dark as gtk(3) theme. 2. Launch chromium browser and open some tabs 3. OBSERVED RESULT Can't tell which is the active tab. EXPECTED RESULT A visible indication of the active tab, I would suggest a darker tab border. SOFTWARE/OS VERSIONS Windows: MacOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: 5.14.5 KDE Frameworks Version: 5.53.0 Qt Version: 5.12.0 ADDITIONAL INFORMATION See screenshot.