Bug 403085

Summary: Bug fix for 402841 seems to have introduced loss of animation playback and sometimes crashing
Product: [Applications] krita Reporter: Ahab Greybeard <ahab.greybeard>
Component: AnimationAssignee: joupent
Status: RESOLVED FIXED    
Severity: major CC: freebox64, griffinvalley, halla, joupent
Priority: NOR    
Version: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Debian stable   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: A very simple animation

Description Ahab Greybeard 2019-01-10 20:55:58 UTC
Created attachment 117391 [details]
A very simple animation

SUMMARY
Bug https://bugs.kde.org/show_bug.cgi?id=402841 was reported fixed by Commit: https://commits.kde.org/krita/aed191675e826f37d1173af49d22 incorporated into the 10 January nightly build 4.2.0 pre-alpha (git 95773b5).

Now, the Play button only advances by one frame and krita will sometimes crash (not easily repeatable) if a simple animation file that has been saved is reloaded and Played. The animation Renders out ok as an .mp4 file.

STEPS TO REPRODUCE
1. Make any simple animation or use the example I attached
2. Play it in the Animation docker
3. 

OBSERVED RESULT
The frame moves to the next frame only (sometimes a few frames) instead of playing over the full range (0 to 50 in the example attached).

EXPECTED RESULT
It should play normally as it does in previous nightly builds.

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: Debian 9 (stable)
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
This is also the case for animation files Saved in previous versions of krita.
I haven't tested this for the Windows nightly build.
Comment 1 mvowada 2019-01-11 09:54:15 UTC
Hi Ahab G.,

I've opened the test file https://bugs.kde.org/attachment.cgi?id=117391 with the latest nightly "krita-4.2.0-pre-alpha-95773b5-x86_64.appimage" and I can easily reproduce the playback stop bug.

I've then checked with the (a few days) older "krita-4.2.0-pre-alpha-0c1da95-x86_64.appimage" and it works well without any playback stops.

Thanks for reporting this. Confirming.
Comment 2 mvowada 2019-01-21 11:58:42 UTC
(Just added the word "animation" to the title for an easier search by summaries)
Comment 3 wolthera 2019-02-14 11:08:36 UTC
https://phabricator.kde.org/R37:1af5c349f0705fa5c14b3740508994a5352e9e6e reverts the breaking commit in question. I'll set this to resolved.