Summary: | Freeze in Strokes/Layers jobs [GDB backtrace] | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | wolthera <griffinvalley> |
Component: | Layer Stack | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | halla, rebecca, scottpetrovic, storm.anthro |
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/krita/0d2f1d16e187a2110e2bf4b21e0d9c23b0871489 | Version Fixed In: | |
Sentry Crash Report: |
Description
wolthera
2019-01-09 19:52:12 UTC
I spent a while testing this with various commits and I might have a potential commit that is causing this. Commit: 5f9123 add a createActions method to KoToolFactoryBase (11/28/2018) When I was testing, I usually had to switch tools a few times to trigger it. Usually between the freehand brush, move, and transform tool. Changing tools and doing something, then clicking some layer visibility icons to test. It eventually triggered after a minute or two. Going back one more commit, the error seemed to disappear. Maybe someone else can test on that commit to see if that is the culprit. That's also the commit causing this bug: https://bugs.kde.org/show_bug.cgi?id=401757 *** Bug 401757 has been marked as a duplicate of this bug. *** Simplest way to reproduce until now * paint * duplicate layer * paint * switch to move tool ---> the outline doesn't get show, so the tool does not get "properly" activated, even though moving works * switch back to first layer: nothing works until we switch layers again. Git commit 0d2f1d16e187a2110e2bf4b21e0d9c23b0871489 by Boudewijn Rempt. Committed on 15/01/2019 at 13:49. Pushed by rempt into branch 'master'. Do not create the move tool option widget twice Flake first activates a tool, then asks it to create its option widget(s). However, the move tool needs to have the option widget created when it's activated, so create the option widget in the constructor of the move tool. This also incidentally fixes the problems with actions only being executed after changing the current node having used the move tool. M +32 -42 plugins/tools/basictools/kis_tool_move.cc M +0 -2 plugins/tools/basictools/kis_tool_move.h https://commits.kde.org/krita/0d2f1d16e187a2110e2bf4b21e0d9c23b0871489 |