Bug 402894

Can not reproduce here, the original disappears the moment a new version is saved. Is your "original" image may not be an original and does it already have an ImageHistory in the metadata?

Maik

I played around a little with the problem and could find out the following:

The behavior depends on the way a new version is created. I have switchen on the "non destructive editing" - I understand that, if this is switchen on there is alsways created a new version - the original image is newer overwritten. Anyhow there are two buttons "save changes" and "save as new version". In both cases a new version is created. For me it is unclear why these two options exist?

1.  If you explicitely save a new version from the editor, the new version is created (..._v1) displayed and the original image is hidden - behaves as intended.

2. If you save 'normal' from the editor, also a new version is created (..._v1) but beside the new version the original image is also always displayed.

In addition I recognized that if you delete the new version of the image in case 1, the original image is still hidden and seems to be lost!

With version 6.1.0 this behaviour seems to be changed and is, at least for me, even more confusing.
Now it is just the opposite: If I save an edited image with "save as new version" a new version is created and oroginal iamage is alway shown regardless of the configuration.
But - If I save the edited image with "save changes" or simply close the editor a new version is created but the original image is hidden depending on the configuration (this is the expected behaviour). It is also possible to switch on and off the original image by clicking the icon at the image in the version tab at the right sidebar.
This is even worse because I can not change the behaviour afterwards.

The behavior in digiKam-6.0.0 was unfortunately wrong and is now correct again from digiKam-6.1.0. Statement:
"Save changes" saves an image derived from the original, if the option in the setup is disabled, the original image is hidden.
"Save as new image" stores an image derived from the original, but as a new branch, the original image is not hidden.

Maik

Hi Maik,

thanks for fast replay! - OK, makes sense and is more straight foreward...

Is there any change to get behaviour to "not show original image" for
all images?

(without deleting and than newly create the new versions)

regards

Dirk




Am 25.05.2019 um 17:07 schrieb Maik Qualmann:
> https://bugs.kde.org/show_bug.cgi?id=402894
>
> --- Comment #4 from Maik Qualmann <metzpinguin@gmail.com> ---
> The behavior in digiKam-6.0.0 was unfortunately wrong and is now correct again
> from digiKam-6.1.0. Statement:
> "Save changes" saves an image derived from the original, if the option in the
> setup is disabled, the original image is hidden.
> "Save as new image" stores an image derived from the original, but as a new
> branch, the original image is not hidden.
>
> Maik
>

Hi,
there is another point when using batch conversions (e.g. RAW to jpeg).
In this case the new (jpeg) images are linked to the RAW files as new version as expected, but:
1. They are not named as ..._v1 (they are only named as .._v1 if the original image exists!)
2. Original image is always shown

I would rearly propose to ALWAYS show the actual image only! Its confusing within slide shows / exports to have several versions of the same image.
If you have to access a previous version you can always use the 'version' tab on the right side bar.

Best regards
Dirk

Hmm, it is not the task of versioning to hide images from export tools or slideshows. You can group RAW and JPEG and set in setup if the tools should use both or just the leader image.

Maik

let me phrase it different...
In general I have the option to display the original image or not and I can toggle this within version tab on the right side bar (small icon). 
But it depends on the way a new version is created if it works. If I create from the editor with "save changes" this works, but if I have saved with "save as new version" this does not work - although the icon exists I can not hide the original image. The same is true for new versions that are created via batch.
I could accept a different default behaviour, but it is completely unclear to me why it is not possible to hide the original image only because the new version is created on a different way.

regards
Dirk

Hmm, "Save as new image" and BQM (currently not adjustable) create a new branch, so a new stand-alone image, as a history they have the original image.

The idea is that you want to make adjustments in the editor of an image, color correction and size crop. With "Save changes" the image is saved as a new version and if set, the original is hidden. If I eventually need the original, I can make it visible again. The whole story is not really meant for RAW images.

Maik

Joining the conversation since I had the same thoughts about versioning, as stated here: http://digikam.1695700.n4.nabble.com/digiKam-users-Showing-original-and-versions-Is-it-working-alright-td4708568.html

I personally thought that "save changes" in the image editor would overwrite the original, and "save as new version" would be the non-destructive editing (but I am wrong).

The fact that the versioning panel actually detects both way of saving a picture as original and version, respectively, makes it more confusing. I would personally hide the original in any case. 

But not for RAW images, that's a separate story and I think it's OK the way it is now.

PS: Also, it would be cool if you could toggle displaying the original/intermediate images in the versioning panel itself, instead of having to go to the settings.

You can switch off the versioning completely, then you over write  the original just. Versioning is about keeping the original forever. Sometimes one has just created a completely different image through editing and it should be independent as a "new" image. I think it's not hard to understand.

Maik

Yes, yes, of course. I like versioning the way it is. That's not the point. 

I just found it confusing that the original and the new version were both shown regardless of the settings, but only if "save changes" was used in the editor, not "save as new version".

(In reply to IWBR from comment #12)
> Yes, yes, of course. I like versioning the way it is. That's not the point. 
> 
> I just found it confusing that the original and the new version were both
> shown regardless of the settings, but only if "save changes" was used in the
> editor, not "save as new version".

yes, all is fine with versioning, except that that the original image should not be shown - at least if it is switched off in version side bar tab...

Git commit b90554b0211058d499ce720b761d2d376ede0417 by Maik Qualmann.
Committed on 12/12/2019 at 20:55.
Pushed by mqualmann into branch 'master'.

the function to show / hide the original image already exists,
draw the icon larger in the versioning view
FIXED-IN: 7.0.0

M  +2    -1    NEWS
M  +10   -9    core/libs/properties/history/versionsoverlays.cpp

https://invent.kde.org/kde/digikam/commit/b90554b0211058d499ce720b761d2d376ede0417