Bug 402837

Summary: kpat / kpatience gives an error on "Help about Freecell" (or other Solitaire variants)
Product: [Applications] kpat Reporter: Shlomi Fish <shlomif>
Component: generalAssignee: Stephan Kulow <coolo>
Status: RESOLVED FIXED    
Severity: normal CC: aacid, kde-games-bugs, montel, yurchor
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Mageia RPMs   
OS: Linux   
See Also: https://bugs.mageia.org/show_bug.cgi?id=24120
Latest Commit: Version Fixed In:

Description Shlomi Fish 2019-01-03 20:05:32 UTC
SUMMARY

kpat / kpatience gives an error on "Help about Freecell" (or "Help about" other Solitaire variants)

It gives this error:

<<<
Could not find filename freecell.html in /usr/share/doc/HTML/en//kpat/freecell.html.
>>>

Version-Release number of selected component (if applicable):

Cauldron. I have both kpat and kpat-handbook installed.

How reproducible:

Always.

STEPS TO REPRODUCE
1. start kpat.
2. Select Freecell.
3. On the menubar, select Help -> Help with Freecell.
4. error.

OBSERVED RESULT

error

EXPECTED RESULT

Display the rules for the solitaire variant.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Mageia v7 x86-64
(available in About System)
KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.53.0
Qt Version: 5.12.0

ADDITIONAL INFORMATION
Comment 1 Shlomi Fish 2019-01-03 20:06:36 UTC
Add link to downstream bug
Comment 2 Albert Astals Cid 2019-01-03 21:35:16 UTC
I'd say Yuri broke this with his changes to khelpclient in https://phabricator.kde.org/D16350
Comment 3 Yuri Chornoivan 2019-01-03 21:53:50 UTC
(In reply to Albert Astals Cid from comment #2)
> I'd say Yuri broke this with his changes to khelpclient in
> https://phabricator.kde.org/D16350

And I'd say this was broken beforehand (not by me even this time). It does not work in Mageia 6 (Applications 17.12, KF 5.42). Just does not work differently (shows index.html when trying to show /usr/share/doc/HTML/en//kpat/index.html#freecell).

It is a bug in KPat. I'll try to create a review request to fix it soon.
Comment 4 Yuri Chornoivan 2019-01-06 06:26:12 UTC
Git commit 0fd079dcfd49d4c66bc6483c36fb49f7529373ee by Yuri Chornoivan.
Committed on 06/01/2019 at 06:26.
Pushed by yurchor into branch 'Applications/18.12'.

Correct help link for the new versions of KF5 (>52)

Summary:
Due to me "broken" KHelpClient in KF 5.52, links in the help menu show error messages now.

Test Plan:
1. Start KPat.
2. Select Freecell.
3. On the menubar, select "Help -> Help with Freecell".
4. Help for Freecell should be shown.

Reviewers: #kde_games, aacid, ltoscano

Reviewed By: ltoscano

Subscribers: ltoscano, kde-games-devel

Differential Revision: https://phabricator.kde.org/D17953

M  +1    -1    mainwindow.cpp

https://commits.kde.org/kpat/0fd079dcfd49d4c66bc6483c36fb49f7529373ee