| Summary: | symlinks to mounted NTFS volumes are hidden in Dolphin | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | kdebugs |
| Component: | general | Assignee: | David Faure <faure> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | globalinterpreterlock, kde, kdebugs, kdelibs-bugs, nate, s_chriscollins, wbauer1 |
| Priority: | NOR | ||
| Version: | 5.50.0 | ||
| Target Milestone: | --- | ||
| Platform: | Kubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kio/01a7e0e757d3558e131d24fbb079b65af7b70572 | Version Fixed In: | 5.57 |
| Sentry Crash Report: | |||
|
Description
kdebugs
2019-01-01 00:03:42 UTC
Weird, I did check for symlinks in the code for ignoring the root volume's hidden flag. const QString fullFilePath = QDir(filename).canonicalPath(); Huh, I see the discussion at https://phabricator.kde.org/D13782 And it does look like that code is in place as you describe: https://cgit.kde.org/kio.git/tree/src/ioslaves/file/file_unix.cpp?h=v5.50.0#n567 I don't know if the umask matters, but as reported above, I use umask=007 in /etc/fstab Hi, just wanted to chime in and say that it looks like I'm affected by the same bug. Copying my comment from 392913: """ I'm experiencing what seems to be the same issue on two separate computers with KDE Frameworks versions above 5.50: Computer 1: Vanilla Arch Linux with Dolphin 18.12.1 with KDE Frameworks 5.54.0 Computer 2: Manjaro with Dolphin 18.12.1 with KDE Frameworks 5.53.0 On both computers, I have NTFS volumes mounted via fstab with default options. Example: UUID=0123456789ABCD /mnt/windows ntfs defaults 0 0 If I then have a symlink under home that points to this directory: windows -> /mnt/windows The symlink only shows in Dolphin if I turn on "Hidden Files" (Alt+.). It makes no difference if the links are made via Dolphin, from the command line etc (and I refreshed multiple times to be sure the links were in Dolphin's view of the FS). This seems to be the same bug, but it's still present in KF > 5.53.0. Should I open a new report with this info? LMK if you need more information or want me to try anything. """ Of note, it seems to be the exact same behavior, but I can confirm this is happening with both KF 5.53.0 and 5.54.0 on Dolphin 18.12.1. Also, on the discussion of umask: on Computer 1, I left the mask setting to default in fstab (0022 for Arch), and set it to umask=0000 in fstab on Computer 2. Well, I can confirm the problem with symlinks here (dolphin 18.12.1, Qt 5.12.0, KF 5.54.0), which is a bit strange because I explicitly tested symlinks back in https://phabricator.kde.org/D13782 and it worked fine then (with the mentioned followup change)... :-/ I did some investigation, and the problem seems to be that ep->d_type = 10 now (which is DT_LNK), i.e. the "if (ep->d_type == DT_DIR || ep->d_type == DT_UNKNOWN)" branch is not taken anymore for some reason. So the fix should be to change that to: if (ep->d_type == DT_DIR || ep->d_type == DT_UNKNOWN || ep->d_type == DT_LNK) I'll test it and submit a patch to phabricator later... (In reply to Wolfgang Bauer from comment #4) > So the fix should be to change that to: > if (ep->d_type == DT_DIR || ep->d_type == DT_UNKNOWN || ep->d_type == DT_LNK) Works for me :-) The fix is on phabricator now: https://phabricator.kde.org/D18479 Fantastic -- thanks! Awesome, thank you! Git commit 01a7e0e757d3558e131d24fbb079b65af7b70572 by Wolfgang Bauer. Committed on 03/03/2019 at 11:53. Pushed by wbauer into branch 'master'. Fix NTFS hidden check for symlinks to NTFS mountpoints A symlink to the mountpoint of an NTFS partition can have the type DT_LNK. So extend the check to cover that case as well. FIXED-IN: 5.57.0 Differential Revision: https://phabricator.kde.org/D18479 M +1 -1 src/ioslaves/file/file_unix.cpp https://commits.kde.org/kio/01a7e0e757d3558e131d24fbb079b65af7b70572 |