Summary: | Light fontstyles for headings are causing visual and legibility issues | ||
---|---|---|---|
Product: | [Frameworks and Libraries] libplasma | Reporter: | Filip Fila <filipfila.kde> |
Component: | components | Assignee: | Marco Martin <notmart> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, gianluca.pettinello, nate |
Priority: | NOR | Keywords: | usability |
Version: | 5.53.0 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-framework/fdc9124687855e8f988c301a6a9b3646d41e9659 | Version Fixed In: | 5.55 |
Description
Filip Fila
2018-12-31 15:19:35 UTC
I very strongly agree. Using thin and wispy styles for headings and titles seems semantically incorrect since they have lower visual weight than their content. It's the opposite effect from what's expected and typical. There's another implementation-specific problem: it often doesn't work. If the appropriate font variant isn't installed, Qt will try its best to fall back to what's available, an the user will either see eithera regular font weight (ruining the intended effect) or a super thin font weight (which is often borderline illegible). I recommend at the minimum using a regular font weight, and potentially even going bold for at least levels 2-5 on the Heading component. Giving headings greater visual prominence is semantically and visually appropriate. Git commit fdc9124687855e8f988c301a6a9b3646d41e9659 by Nate Graham, on behalf of Filip Fila. Committed on 10/01/2019 at 16:14. Pushed by ngraham into branch 'master'. [frameworks] Do not use light font styles for headings (1/3) Summary: This patch turns off light font styles for some headings because they cause visual and legibility issues, as explained in the respective bug report. FIXED-IN: 5.54 Test Plan: **//Worst case scenario testing//** - font does not have a "light" variant and falls back to using a thinner one such as "hairline" **Before:** {F6520036} {F6520035} {F6520034} **After:** {F6520039} {F6520038} {F6520037} **//Plasma defaults testing//** **Before**: {F6520778} {F6520777} {F6520776} **After:** {F6520781} {F6520780} {F6520779} Reviewers: ngraham, #plasma, #vdg, #frameworks Reviewed By: ngraham, #vdg Subscribers: #frameworks, #plasma, #vdg, ngraham, abetts, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D17905 M +0 -2 src/declarativeimports/plasmaextracomponents/qml/Heading.qml M +0 -2 src/declarativeimports/plasmaextracomponents/qml/Title.qml https://commits.kde.org/plasma-framework/fdc9124687855e8f988c301a6a9b3646d41e9659 Git commit e5d392cb79f9496dd5baeda5ede628d1b75ce84c by Nate Graham, on behalf of Filip Fila. Committed on 10/01/2019 at 16:18. Pushed by ngraham into branch 'master'. [kirigami] Do not use light font styles for headings (2/3) Summary: This patch turns off light font styles for some headings because they cause visual and legibility issues, as explained in the respective bug report. FIXED-IN: 5.54 Test Plan: **//Worst case scenario testing//** - font does not have a "light" variant and falls back to using a thinner one such as "hairline" **Before:** {F6520053} **After:** {F6520055} **//Plasma defaults testing//** **Before:** {F6520791} **After:** {F6520792} Reviewers: ngraham, #plasma, #vdg, #frameworks, mart Reviewed By: ngraham, #plasma, #vdg, mart Subscribers: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, plasma-devel Tags: #kirigami Differential Revision: https://phabricator.kde.org/D17906 M +0 -2 src/controls/Heading.qml https://commits.kde.org/kirigami/e5d392cb79f9496dd5baeda5ede628d1b75ce84c Git commit dc901a1f0b5f6621bfa1c23e33dcfdf6246e7cb1 by Nate Graham, on behalf of Krešimir Čohar. Committed on 10/01/2019 at 16:25. Pushed by ngraham into branch 'master'. [KWidgetsAddons] Do not use light font styles for headings (3/3) Summary: This patch brings back regular font styles for headings to KTitleWidget for the sake of consistency with QML and Kirigami, where they were also reintroduced in favor of better legibility. FIXED-IN: 5.54 Test Plan: Before: {F6520054} After: {F6520058} Reviewers: ngraham, #frameworks, #vdg, #plasma Reviewed By: ngraham, #vdg Subscribers: cfeck, filipf, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D17907 M +0 -29 src/ktitlewidget.cpp https://commits.kde.org/kwidgetsaddons/dc901a1f0b5f6621bfa1c23e33dcfdf6246e7cb1 I like the thin character, looks to me professional. Is it possible to have it under font configuration (e.g. use thin fonts) so that if somebody wants can use thin fonts? KDE is configurability after all :) Ciao Gianulca You already can, sort of. What you can't currently do is choose the font size/style etc. just for headings. That's something we do want to implement/ Thanks Nate for the(In reply to Nate Graham from comment #6) > You already can, sort of. What you can't currently do is choose the font > size/style etc. just for headings. That's something we do want to implement/ Thanks Nate *** Bug 403365 has been marked as a duplicate of this bug. *** |