Bug 402520

Summary:	No gui translations available from binary factory
Product:	[Applications] umbrello	Reporter:	Ralf Habacker <ralf.habacker>
Component:	installer/packages	Assignee:	Umbrello Development Group <umbrello-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jess.jones.unitedkingdom, julius.kuenzel, vonreth
Priority:	NOR
Version First Reported In:	2.27.0 (KDE Applications 18.12.0)
Target Milestone:	---
Platform:	Other
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Bug Depends on:
Bug Blocks:	373980

Description Ralf Habacker 2018-12-24 09:44:13 UTC

Winbows binary packages build from KDE binary factory does not contain any gui translations.

STEPS TO REPRODUCE
1. download portable package https://binary-factory.kde.org/job/Umbrello_Nightly_win64/
2. unpack archive and search for *.mo files 

OBSERVED RESULT
There are no translation files included

EXPECTED RESULT
Translation files should be included

ADDITIONAL INFORMATION
Ben Cooksley told me that providing release builds from a tarball should have gui translations. 

Related review request has been opened with https://phabricator.kde.org/D17675

Comment 1 Hannah von Reth 2018-12-24 11:39:12 UTC

Git repos don't provide translations.
The ecm process to provides them relies on releaseme which doesn't support windows

Comment 2 Ralf Habacker 2018-12-24 13:27:00 UTC

(In reply to Hannah von Reth from comment #1)
> Git repos don't provide translations.
> The ecm process to provides them relies on releaseme which doesn't support
> windows

As far as I understand Ben, it is possible by using tar balls for example from https://download.kde.org/stable/applications/18.12.0/src/, which contains po files.

Comment 3 Hannah von Reth 2018-12-24 13:36:28 UTC

Yes. Stable blueprint targets should always provide tarballs and thus translations.

Comment 4 Ralf Habacker 2020-09-10 23:32:05 UTC

(In reply to Hannah von Reth from comment #3)
> Yes. Stable blueprint targets should always provide tarballs and thus
> translations.

I tried that with a recent release version from https://binary-factory.kde.org/job/Umbrello_Release_win64/634/, but there are no locale related files included (*.mo files)

Comment 5 Ralf Habacker 2021-03-08 20:50:46 UTC

(In reply to Ralf Habacker from comment #4)
> (In reply to Hannah von Reth from comment #3)
> > Yes. Stable blueprint targets should always provide tarballs and thus
> > translations.

For unstable (or staging=master) builds on binary factory, a similar solution as on obs can be used by using an auxiliary script to support translations, as is done with https://build.opensuse.org/package/view_file/windows:mingw:win32:snapshots/mingw32-kmymoney5/manage-translations?expand=1 (in the %prep step).

It can work in two modes: 
1. it can use a publicly available tarball from the latest version of the associated app, or it can build a translation repository (on the fly or as a predefined tarball added to the build receipt).

In either case, the script extracts the translations (app messages and documents) and applies them to the latest source code pulled from a Git repository.
Subsequently, the CMake build system is adapted so that ki18n generates the (binary) files required for the translations.

Comment 6 Hannah von Reth 2021-03-10 09:04:22 UTC

Actually ecm offers support for that https://invent.kde.org/frameworks/extra-cmake-modules/-/blob/master/kde-modules/KDECMakeSettings.cmake#L320 
It relies on release me.
Last time I checked releasme hat only a generel dependency check looking for tools absolutely not needed for this task, it would also need some windows porting besides of that.

Comment 7 Oliver Kellogg 2022-02-14 05:44:31 UTC

*** Bug 449659 has been marked as a duplicate of this bug. ***

Comment 8 Julius Künzel 2024-03-16 18:36:15 UTC

Now that translations are pushed to the source code by Scripty this should be fixed. Feel free to open if not