Bug 402490

Summary: filter notifications from kdeconnect for when forwarding to other instance
Product: [Applications] kdeconnect Reporter: azrdev
Component: android-applicationAssignee: Albert Vaca Cintora <albertvaka>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 1.10   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/kdeconnect-android/501af459419aa55fcec864544e1a15e185309530 Version Fixed/Implemented In:
Sentry Crash Report:

Description azrdev 2018-12-23 09:22:03 UTC 
Given three devices with kdeconnect (e.g. phones A,B, and Desktop D), one can get duplicate notifications on a single device: Say D is telling via MPRIS which music it is playing, then both phones A and B show a notification about that due to the mpris module. However, this notification gets mirrored to the respective other phone via the send/receive notifications module.

I therefore suggest that the "send notifications" module recognizes notifications which have been generated by kdeconnect itself, and doesn't advertise them to the remote receiver.

Related to https://bugs.kde.org/show_bug.cgi?id=402488
Comment 1 Nicolas Fella 2018-12-24 21:36:07 UTC 
Git commit 501af459419aa55fcec864544e1a15e185309530 by Nicolas Fella.
Committed on 24/12/2018 at 21:35.
Pushed by nicolasfella into branch 'master'.

Don't send our own notifications

Summary:
They were silent anyway and are not really useful

Test Plan: I don't see the MPRIS notification in the plasmoid any more

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D17776

M  +5    -6    src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationsPlugin.java

https://commits.kde.org/kdeconnect-android/501af459419aa55fcec864544e1a15e185309530