| Summary: | Alternate screen buffer scrolling gets disabled after reset | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Nikos Chantziaras <realnc> |
| Component: | kpart | Assignee: | Konsole Bugs <konsole-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | a.samirh78, nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/konsole/b545a812e3bf74157387fd60b61f6e2146723834 | Version Fixed/Implemented In: | 18.12.1 |
| Sentry Crash Report: | |||
|
Description
Nikos Chantziaras
2018-12-22 15:14:50 UTC
Should be fixed by https://phabricator.kde.org/D17781 I forgot to say, thank you for finding a way to reproduce this issue, (I've been hit by it several times, and it was driving me up the wall). The patch applies cleanly to Konsole 18.12.0 and fixes the issue. Thanks! Git commit c9276130ac06f052f9251d8d67eaf45ff2f87708 by Kurt Hindenburg, on behalf of Ahmad Samir.
Committed on 25/12/2018 at 01:41.
Pushed by hindenburg into branch 'master'.
Don't change alternate scrolling state after calling reset()
Summary:
Alternate Scrolling shouldn't be reset when calling resetModes(), this
is to maintain the profile alternate scrolling property after reset()
is called, otherwise calling reset() (or clear scrollback and reset)
will always make alternate scrolling get disabled regardless of the
respective profile property.
Also this matches XTerm behavior.
Test Plan:
1 - Open a new tab and make sure the alternate scrolling profile property
is enabled
2 - Run less or any other application that uses the alternate screen,
scrolling with the mouse should work
3 - Quit the previous application and execute `reset`
4 - Repeat 2, notice that now scrolling doesn't work
After applying the patch, alternate scrolling mode is not changed after
calling reset.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: konsole-devel, hindenburg
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D17781
M +4 -1 src/Vt102Emulation.cpp
https://commits.kde.org/konsole/c9276130ac06f052f9251d8d67eaf45ff2f87708
Git commit b545a812e3bf74157387fd60b61f6e2146723834 by Kurt Hindenburg, on behalf of Ahmad Samir.
Committed on 25/12/2018 at 01:42.
Pushed by hindenburg into branch 'Applications/18.12'.
Don't change alternate scrolling state after calling reset()
Summary:
Alternate Scrolling shouldn't be reset when calling resetModes(), this
is to maintain the profile alternate scrolling property after reset()
is called, otherwise calling reset() (or clear scrollback and reset)
will always make alternate scrolling get disabled regardless of the
respective profile property.
Also this matches XTerm behavior.
Test Plan:
1 - Open a new tab and make sure the alternate scrolling profile property
is enabled
2 - Run less or any other application that uses the alternate screen,
scrolling with the mouse should work
3 - Quit the previous application and execute `reset`
4 - Repeat 2, notice that now scrolling doesn't work
After applying the patch, alternate scrolling mode is not changed after
calling reset.
Reviewers: #konsole, hindenburg
Reviewed By: #konsole, hindenburg
Subscribers: konsole-devel, hindenburg
Tags: #konsole
Differential Revision: https://phabricator.kde.org/D17781
(cherry picked from commit c9276130ac06f052f9251d8d67eaf45ff2f87708)
M +4 -1 src/Vt102Emulation.cpp
https://commits.kde.org/konsole/b545a812e3bf74157387fd60b61f6e2146723834
|