| Summary: | Falkon fails to build with Qt 5.12 and current Framworks | ||
|---|---|---|---|
| Product: | [Applications] Falkon | Reporter: | bluescreenavenger |
| Component: | general | Assignee: | David Rosca <nowrep> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nicolas.fella |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/falkon/51323c62e397feda3e3856bf2b696d2612c70e45 | Version Fixed In: | |
I think it was caused by https://cgit.kde.org/falkon.git/commit/?id=7bca744cabb2d4f8f825a90ce1b2bf266a8c7efb Git commit 51323c62e397feda3e3856bf2b696d2612c70e45 by Nicolas Fella. Committed on 31/12/2018 at 15:27. Pushed by nicolasfella into branch 'master'. Fix build Summary: BUG: 402401 Test Plan: Builds Reviewers: drosca Reviewed By: drosca Subscribers: falkon Tags: #falkon Differential Revision: https://phabricator.kde.org/D17811 M +3 -2 src/plugins/KDEFrameworksIntegration/kdeframeworksintegrationplugin.cpp https://commits.kde.org/falkon/51323c62e397feda3e3856bf2b696d2612c70e45 |
Trying to build Falkon, I get this error: [ 89%] Building CXX object autotests/CMakeFiles/adblocktest.dir/qrc_autotests.cpp.o /srcbuild/falkon/src/plugins/KDEFrameworksIntegration/kdeframeworksintegrationplugin.cpp: In constructor ‘KDEFrameworksIntegrationPlugin::KDEFrameworksIntegrationPlugin()’: /srcbuild/falkon/src/plugins/KDEFrameworksIntegration/kdeframeworksintegrationplugin.cpp:43:45: error: no matching function for call to ‘Purpose::Menu::Menu(KDEFrameworksIntegrationPlugin*)’ , m_sharePageMenu(new Purpose::Menu(this)) ^ In file included from /opt/include/KF5/purposewidgets/PurposeWidgets/Menu:1, from /srcbuild/falkon/src/plugins/KDEFrameworksIntegration/kdeframeworksintegrationplugin.h:22, from /srcbuild/falkon/src/plugins/KDEFrameworksIntegration/kdeframeworksintegrationplugin.cpp:18: /opt/include/KF5/purposewidgets/purposewidgets/menu.h:35:14: note: candidate: ‘Purpose::Menu::Menu(QWidget*)’ explicit Menu(QWidget* parent = nullptr); ^~~~ /opt/include/KF5/purposewidgets/purposewidgets/menu.h:35:14: note: no known conversion for argument 1 from ‘KDEFrameworksIntegrationPlugin*’ to ‘QWidget*’ /srcbuild/falkon/src/plugins/KDEFrameworksIntegration/kdeframeworksintegrationplugin.cpp: In member function ‘virtual void KDEFrameworksIntegrationPlugin::populateWebViewMenu(QMenu*, WebView*, const WebHitTestResult&)’: /srcbuild/falkon/src/plugins/KDEFrameworksIntegration/kdeframeworksintegrationplugin.cpp:104:57: error: no matching function for call to ‘QJsonValue::QJsonValue(QUrl)’ { QStringLiteral("urls"), QJsonValue(view->url()) }, ^ In file included from /opt/include/QtCore/qjsonobject.h:43, from /opt/include/QtCore/qplugin.h:45, from /opt/include/QtCore/QtPlugin:1, from /srcbuild/falkon/src/lib/plugins/plugininterface.h:21, from /srcbuild/falkon/src/plugins/KDEFrameworksIntegration/kdeframeworksintegrationplugin.h:20, from /srcbuild/falkon/src/plugins/KDEFrameworksIntegration/kdeframeworksintegrationplugin.cpp:18: /opt/include/QtCore/qjsonvalue.h:156:5: note: candidate: ‘QJsonValue::QJsonValue(QJsonPrivate::Data*, QJsonPrivate::Base*, const QJsonPrivate::Value&)’ QJsonValue(QJsonPrivate::Data *d, QJsonPrivate::Base *b, const QJsonPrivate::Value& v); ^~~~~~~~~~ Let me know if more info is needed?