| Summary: | coregrind/vgdb-invoker-solaris.c: 2 * poor error checking ? | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | dcb314 |
| Component: | general | Assignee: | Julian Seward <jseward> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | philippe.waroquiers |
| Priority: | NOR | ||
| Version: | 3.15 SVN | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
Fix done in 59f0855049a1. However, I do not have access to a Solaris system, so maybe the result does not even compile :). Please verify and re-open in case the fix is wrong. Thanks for reporting the bug. |
SUMMARY 1. [valgrind/coregrind/vgdb-invoker-solaris.c:177]: (style) Checking if unsigned variable 'bytes' is less than zero. bytes = read(status_fd, &pstatus, sizeof(pstatus)); if ((bytes < 0) || (bytes != sizeof(pstatus))) { but size_t bytes = sizeof(ctl.cmd) + sizeof(ctl.arg.flags); The return type of read is ssize_t, not size_t, isn't it ? 2. [valgrind/coregrind/vgdb-invoker-solaris.c:404]: (style) Checking if unsigned variable 'bytes' is less than zero. Duplicate. STEPS TO REPRODUCE 1. 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: MacOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION