Bug 402330

Summary:	error importing QIF File "SKGImportPluginQif::importFile() RC=[ERR-5]: SKGCategoryObject::addCategory failed because linked object is not yet saved in the database."
Product:	[Applications] skrooge	Reporter:	skierpage <info>
Component:	general	Assignee:	Stephane MANKOWSKI <stephane>
Status:	RESOLVED FIXED
Severity:	normal	CC:	stephane
Priority:	NOR
Version:	2.17.0
Target Milestone:	25.1.0
Platform:	Flatpak
OS:	Linux
Latest Commit:	https://commits.kde.org/skrooge/454e7c178eab0ea7af4295ef0e18508d4f9947cd	Version Fixed In:
Sentry Crash Report:
Attachments:	hand-edited QIF file of a transaction with tag but no category

Description skierpage 2018-12-19 00:28:00 UTC

SUMMARY
I tried to import a large .QIF file exported from Quicken 2012 with a decade of transactions. It eventually failed with
  [ERR-5]: Import of file named 'file:///media/Windows/path/to/QDATA_export_all.QIF' failed

with no other useful info.
(The good news is simpler QIF files import OK in the latest Skrooge version, many thanks!)

STEPS TO REPRODUCE
1. Export QIF file from Quicken 2012 containing only transactions.
2. In Skrooge, File > Import > Import... this QIF file

OBSERVED RESULT
After 30+ seconds, Skrooge displays the red message
  [ERR-5]: Import of file named 'file:///media/Windows/path/to/QDATA_export_trans.QIF' failed
and no new transactions or accounts are created.

If in console I export SKGTRACE=5 before running skrooge, then around the failure the terminal output is:

##      >virtual SKGError SKGDocument::endTransaction(bool)
##      <virtual SKGError SKGDocument::endTransaction(bool) RC=[SUC-0]
##      >virtual SKGError SKGDocument::endTransaction(bool)
##      <virtual SKGError SKGDocument::endTransaction(bool) RC=[SUC-0]
##    <virtual SKGError SKGImportPluginQif::importFile() RC=[ERR-5]: SKGCategoryObject::addCategory failed because linked object is not yet saved in the database.
##    >virtual SKGError SKGDocument::endTransaction(bool)
##    <virtual SKGError SKGDocument::endTransaction(bool) RC=[SUC-0]
##  <SKGError SKGImportExportManager::importFile() RC=[ERR-5]: SKGCategoryObject::addCategory failed because linked object is not yet saved in the database.
##  >virtual SKGError SKGDocument::endTransaction(bool)
##  <virtual SKGError SKGDocument::endTransaction(bool) RC=[SUC-0]
##  >static KMessageWidget* SKGMainPanel::displayErrorMessage(const SKGError&, QAction*, bool)
##  WARNING: Audio notification requested, but sound file from notifyrc file was not found, aborting audio notification
##  <static KMessageWidget* SKGMainPanel::displayErrorMessage(const SKGError&, QAction*, bool)

EXPECTED RESULT
Successful import of transactions.

SOFTWARE/OS VERSIONS

Linux/KDE Plasma: Fedora 29 KDE spin
(available in About System)
KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.53.0 in Flatpak, 5.52.0 on desktop
Qt Version: 5.11.3 in Flatpak, 5.11.1 on Desktop

ADDITIONAL INFORMATION
I was able to import a QIF file with just my cash transactions, so maybe the error is in securities import, some old transaction (I've upgrade Quicken several times), or something else complicated. I will try to narrow it down and supply a test file.

Is there any way to get Skrooge to log the details of the transaction that fails to import (e.g. strace it)?

Comment 1 Stephane MANKOWSKI 2018-12-19 09:09:53 UTC

Could you generate traces like this?
export SKGTRACE=10
export SKGTRACESQL=1
skrooge > traces.txt 2>&1

Comment 2 Stephane MANKOWSKI 2018-12-19 09:12:15 UTC

And better, could you provide me a sample qif file reproducing the issue?
You can send me it by mail. My email is in the "About" of Skrooge.

Comment 3 Stephane MANKOWSKI 2018-12-29 20:25:48 UTC

Do you have an answer?

Comment 4 Stephane MANKOWSKI 2019-01-28 11:07:13 UTC

Do you have an answer?

Without answer, I won't be able to fix this issue. So, the bug will be closed "NOT FIXED".

Thank you in advance for your help.

Comment 5 skierpage 2019-01-29 09:57:39 UTC

Created attachment 117715 [details]
hand-edited QIF file of a transaction with tag but no category

Comment 6 skierpage 2019-01-29 10:06:05 UTC

(In reply to Stephane MANKOWSKI from comment #1)
> Could you generate traces like this?
> export SKGTRACE=10
> export SKGTRACESQL=1
> skrooge > traces.txt 2>&1

Sorry for my delay, thanks for your patience! Back in Windows I generated all kinds of QIF export files. Using the date from an SQL debug line just before the fail I was able to narrow down to a particular day's transaction (attached).

In that one transaction, the category line is just
    L/Spouse
i.e. I assigned a tag (like a Skrooge tracker) but no category. I think with the fix for bug 400724, Skrooge import treats tags as a subcategory of the (sub)category, and if there's no category, this fails.

I filed bug 403725 requesting the enhancement to import Quicken tags as Trackers, not a subcategory. Addressing that enhancement would probably fix this bug.

I guess the workaround is to edit the QIF file and replace ^L/ with LDummy Category/

Comment 7 Stephane MANKOWSKI 2019-01-29 20:06:08 UTC

Git commit 454e7c178eab0ea7af4295ef0e18508d4f9947cd by Stephane MANKOWSKI.
Committed on 29/01/2019 at 20:04.
Pushed by smankowski into branch 'master'.

error importing QIF File "SKGImportPluginQif::importFile() RC=[ERR-5]: SKGCategoryObject::addCategory failed because linked object is not yet saved in the database.

M  +1    -0    CHANGELOG
M  +2    -0    plugins/import/skrooge_import_qif/skgimportpluginqif.cpp
A  +9    -0    tests/input/skgtestimportqif2/402330.qif
M  +14   -0    tests/skgbankmodelertest/skgtestimportqif2.cpp

https://commits.kde.org/skrooge/454e7c178eab0ea7af4295ef0e18508d4f9947cd