Bug 402329

Summary:	The vector shape's repeat type of gradient is not saved.
Product:	[Applications] krita	Reporter:	OK <asimofu>
Component:	Tools/Vector	Assignee:	vanyossi <ghevan>
Status:	RESOLVED FIXED
Severity:	normal	CC:	freebox64, ghevan
Priority:	NOR
Version First Reported In:	4.1.7
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:	https://invent.kde.org/kde/krita/commit/0d0e0a159328d8802933d39cc31353f8bc292e10	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	(Video example)

Description OK 2018-12-19 00:17:58 UTC

1. Make a rectangle in vector layer.
2. Select the rectangle and set the fill color to gradient
3. Set the repeat type of the gradient to "repeat"
4. Save the file and quit krita.
5. Load the file, but the repeat type of the shape is not saved.


SOFTWARE/OS VERSIONS
Windows: Win10

Comment 1 mvowada 2018-12-19 09:06:37 UTC

Thanks for the report (confirming with Krita 4.2.0-pre-alpha (git 95b09ea) - Ubuntu 14.04).

Comment 2 OK 2018-12-19 13:56:54 UTC

I found that the Line Style of a vector shape is not also saved.

Comment 3 mvowada 2018-12-19 22:24:03 UTC

Created attachment 117017 [details]
(Video example)

Video example of the "repeat" gradient ignored at reopening ("Fill" and "Stroke").

Comment 4 mvowada 2018-12-19 22:27:06 UTC

Let's keep the report confirmed

Comment 5 OK 2019-09-16 06:21:30 UTC

It seems that it has not been fixed in the current version (krita-nightly-x64-v4.2.6-105-g714a51bdd0).

Thanks to you, the line style is saved correctly now.
But the repeat type of vector shape is not saved still.

Is it difficult to implement?

Comment 6 vanyossi 2019-09-25 03:05:06 UTC

Git commit 6fefdb7b48105a08edde8acd4b20c9a54d1fa53c by Ivan Yossi.
Committed on 25/09/2019 at 03:04.
Pushed by ivany into branch 'master'.

Fix spread Mode not loading on svg parse

Removed private QGradient::Spread usage and instead use
private QGradient member. This copies correctly on qMap
assign during svg parsing

M  +2    -2    libs/flake/svg/SvgGradientHelper.cpp
M  +0    -1    libs/flake/svg/SvgGradientHelper.h

https://invent.kde.org/kde/krita/commit/6fefdb7b48105a08edde8acd4b20c9a54d1fa53c

Comment 7 Halla Rempt 2019-10-03 12:28:58 UTC

Git commit 0d0e0a159328d8802933d39cc31353f8bc292e10 by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 03/10/2019 at 12:27.
Pushed by rempt into branch 'krita/4.2'.

Fix spread Mode not loading on svg parse

Removed private QGradient::Spread usage and instead use
private QGradient member. This copies correctly on qMap
assign during svg parsing

M  +2    -2    libs/flake/svg/SvgGradientHelper.cpp
M  +0    -1    libs/flake/svg/SvgGradientHelper.h

https://invent.kde.org/kde/krita/commit/0d0e0a159328d8802933d39cc31353f8bc292e10