Bug 402252

Summary:	Binding loop detected for property "height" in KickoffItem.qml
Product:	[Plasma] plasmashell	Reporter:	Filip Fila <filipfila.kde>
Component:	Application Launcher (Kickoff) widget	Assignee:	David Edmundson <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	plasma-bugs-null
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	unspecified
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-desktop/be189b0ce2b728cf7e3721b381c24a418d2d1e77	Version Fixed/Implemented In:
Sentry Crash Report:

Description Filip Fila 2018-12-17 18:20:52 UTC

SUMMARY
file:///usr/share/plasma/plasmoids/org.kde.plasma.kickoff/contents/ui/KickoffItem.qml:114:5: QML QQuickText: Binding loop detected for property "height".


STEPS TO REPRODUCE
1. Use master 
2. Run plasmashell in a terminal
3. Open Kickoff

OBSERVED RESULT
Binding loop.

EXPECTED RESULT
No binding loop.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: KDE Neon Developer Edition Unstable (17/12/2018)
KDE Plasma Version: 5.14.80
KDE Frameworks Version: 5.54.0
Qt Version: 5.11.2

Comment 1 David Edmundson 2018-12-19 12:56:19 UTC

Git commit be189b0ce2b728cf7e3721b381c24a418d2d1e77 by David Edmundson.
Committed on 19/12/2018 at 12:56.
Pushed by davidedmundson into branch 'master'.

remove binding loop in KickoffItem

Summary:
For non-wrapped text, implicitHeight will be the height of the
paintedText. The key difference is it won't re-evaluate except on text
changing which removes the binding loop.

Test Plan:
Opened kickoff
Looked identical
No more warnings

Reviewers: #plasma, broulik

Reviewed By: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17642

M  +4    -4    applets/kickoff/package/contents/ui/KickoffItem.qml

https://commits.kde.org/plasma-desktop/be189b0ce2b728cf7e3721b381c24a418d2d1e77