Bug 402223

Summary: No option for multiple select files when selecting wallpapers dolphin
Product: [Plasma] plasmashell Reporter: Sameer Dhar <sdhar>
Component: Image & Slideshow wallpaper pluginsAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: wishlist CC: elvis.angelaccio, kde, kde, plasma-bugs
Priority: NOR    
Version: 5.14.4   
Target Milestone: 1.0   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: https://commits.kde.org/plasma-workspace/b9549351c2c7044584d75e40f0a55e7497a915c0 Version Fixed In: 5.15.0
Sentry Crash Report:

Description Sameer Dhar 2018-12-17 04:56:56 UTC 
SUMMARY
Select Wallpapers has no way to select multiple files at once or to select a folder of images. WOuld make managing wallpapers slightly easier and is possible in other desktop managers like OSX. 

STEPS TO REPRODUCE
1. Configure desktop
2. Select files
3. Try to ctrl-click to select multiple images

OBSERVED RESULT
You must select  each wallapaper image separately

EXPECTED RESULT
You can select multiple files or folders and have them all add to the wallpaper directory magically


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedoa 29 Desktop 
(available in About System)
KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.52.0
Qt Version: 5.11.1

ADDITIONAL INFORMATION
If it's not too hard, I could take a look, I have been able to find dolphin's source code.
Comment 1 Kai Uwe Broulik 2018-12-17 08:07:48 UTC 
You might want to be using the Slideshow wallpaper instead?

This part of the code isn't in Dolphin but plasma: https://cgit.kde.org/plasma-workspace.git/tree/wallpapers/image/image.cpp#n625
Comment 2 Sameer Dhar 2018-12-17 14:16:30 UTC 
Interesting, thanks for the link. I don't actually want to have multiple desktop images like Slideshow, but I wanted to be able to manage them all in the wallpapers section. For instance I want to try a few new wallpapers. In the current workflow I have to select  each one separately instead of ctrl-clicking or adding by folder.
Comment 3 Kai Uwe Broulik 2018-12-17 14:46:21 UTC 
Changing that shouldn't be too hard. You can also drag images into the dialog, where dragging multiple works.
Comment 4 Sameer Dhar 2018-12-17 16:21:51 UTC 
Huh,  I never knew that. I think that will be hard to discover. What's the process for changing stuff in Plasma? Pull request?
Comment 5 David Edmundson 2018-12-17 16:33:16 UTC 
Effectively a pull request: https://community.kde.org/Infrastructure/Phabricator
Comment 6 Sameer Dhar 2018-12-17 17:15:18 UTC 
OK, I will take a look maybe get my first patch in if that sounds reasonable. The simplest case would be adding support to control-click multiple images I think.
Comment 7 Nate Graham 2018-12-27 20:08:54 UTC 
Git commit b9549351c2c7044584d75e40f0a55e7497a915c0 by Nate Graham.
Committed on 27/12/2018 at 20:08.
Pushed by ngraham into branch 'master'.

[Wallpaper] Allow adding multiple images at once from the file picker dialog

Summary:
FIXED-IN: 5.15.0

Test Plan: Added multiple images from the file dialog. They all showed up in the wallpaper grid.

Reviewers: #konsole, broulik, davidedmundson

Reviewed By: davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17815

M  +4    -2    wallpapers/image/image.cpp

https://commits.kde.org/plasma-workspace/b9549351c2c7044584d75e40f0a55e7497a915c0