Bug 402050

Summary: Commit 1df657b4066d introduces wrongly sized pages in pageRow
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Jan Mulder <jlmulder>
Component: generalAssignee: Marco Martin <notmart>
Status: REPORTED ---    
Severity: normal CC: nate
Priority: NOR    
Version First Reported In: Master   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Jan Mulder 2018-12-12 15:00:17 UTC
Unfortunately, I do not have a small demonstrator for this issue, but I bisected my problem to commit 1df657b4066d (basic support for hidden pages). While developing for the open source project Subsurface-Mobile, I encounter the following strange behavior: Open the app, and make sure its not in wideMode, select map, select a dive flag, go back to the dive list, and select the dive in the list, causing it to show its details. A blank page is shown, and swiping to the right shows that the new page has 2x the width it should have (or the a bogus, empty page created, that is difficult to see).

As said. Bisected this to 1df657b4066d. Tried to fix this, and succeeded, but as I do not understand how 1df657b4066d introduces the described problem, producing any fix for this (without introducing another bug) is not the way to go.

STEPS TO REPRODUCE: see above. Source code can be found at https://github.com/Subsurface-divelog/subsurface

OBSERVED RESULT: see above.

EXPECTED RESULT: obvious.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
(available in About System)
KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.53
Qt Version:  5.12.0

ADDITIONAL INFORMATION: the delta below fixes the issue me:

777c777
<                         target: container
---
>                       target: container
779a780,785
>                   PropertyChanges {
>                       target: container.page.anchors
>                       rightMargin: {
>                           return -(root.width - pagesLogic.roundedDefaultColumnWidth*2);
>                       }
>                   }
Comment 1 Marco Martin 2019-03-05 17:07:09 UTC
is it still present on master?
pagerow was rewritten
Comment 2 Jan Mulder 2019-03-06 17:23:02 UTC
I tried to compile our app against Kirigami commit 8ea2fd7f571d. It seems that commit dfa8c507d70af49 forgot to update the kirigami.grc resource file.

That fixed, and updating our Subsurface-mobile build, for added source files, I was able to build our app. Unfortunately, other bugs (unsure its in our app or the current Kirigami master), prevent me from truly evaluating this bug (402050), so I really cannot tell if its fixed or not.