Bug 402013

Summary:	Cannot close Kate on conflicting changes
Product:	[Applications] kate	Reporter:	Alexander Potashev <aspotashev>
Component:	application	Assignee:	KWrite Developers <kwrite-bugs-null>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	silas.lenz
Priority:	NOR
Version First Reported In:	18.08.3
Target Milestone:	---
Platform:	Fedora RPMs
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Alexander Potashev 2018-12-11 18:27:49 UTC

SUMMARY
Cannot close Kate on conflicting changes.

STEPS TO REPRODUCE
1. Create a file (e.g. 1.txt)
2. Open the file in Kate.
3. Make some changes in Kate (don't save!)
4. Open 1.txt in Vim and make some changes, save it in Vim.
5. Try to close Kate by clicking the cross in window title, you will be asked what to do with changes in a dialog box: Overwrite/Reload/Ignore Changes.
6. Click "Ignore Changes" or try to close the dialog by clicking the cross in window title.

OBSERVED RESULT
Nothing happens.

EXPECTED RESULT
Either close the dialog and get back the previous state (before trying to close Kate), or close Kate without writing anything into 1.txt.

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: Fedora 29
(available in About System)
KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.52.0
Qt Version: 5.11.1

ADDITIONAL INFORMATION

Comment 1 Silas Lenz 2018-12-11 20:38:46 UTC

Tried to reproduce. What I believe is happening is that the file (1.txt) is unchecked in the in the list of the window titled "Documents modified on disk" and thus clicking "Ignore Changes" does nothing as no file is selected. Could you confirm this?

While that is technically a correct behavior, it would probably be more intuitive to disable the buttons when no file is selected and select all modified files by default (which happened for me on all but the first try).

Comment 2 Alexander Potashev 2018-12-11 20:53:28 UTC

(In reply to Silas Lenz from comment #1)
> Tried to reproduce. What I believe is happening is that the file (1.txt) is
> unchecked in the in the list of the window titled "Documents modified on
> disk" and thus clicking "Ignore Changes" does nothing as no file is
> selected. Could you confirm this?

You are right. Sorry for the noise.

> While that is technically a correct behavior, it would probably be more
> intuitive to disable the buttons when no file is selected and select all
> modified files by default (which happened for me on all but the first try).

Yeah, may be disable the buttons and add tooltips to tell the user why they are disabled. Or let the user click and then show a warning tell that something must be checked in the list.

Comment 3 Bug Janitor Service 2018-12-26 03:44:20 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 4 Christoph Feck 2018-12-26 05:44:33 UTC

Silas, does comment #2 provide the requested information? Please set the bug status or add a comment.

Comment 5 Silas Lenz 2018-12-28 01:12:30 UTC

> Silas, does comment #2 provide the requested information? Please set the bug status or add a comment.

Yes, closing this as NOT A BUG. I might submit a patch to make this a bit clearer later on.