Bug 401932

Summary: KCM don't display that documentation is available
Product: [Applications] systemsettings Reporter: carl <schwancarl>
Component: generalAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: kde, kde, lueck
Priority: NOR    
Version First Reported In: 5.14.3   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Example workspace behavious

Description carl 2018-12-09 17:36:30 UTC
Created attachment 116814 [details]
Example workspace behavious

SUMMARY

Some KCM don't show that they have some documentation (help button deactivated) but are documented. Example Workspace Behavior, https://docs.kde.org/trunk5/en/kde-workspace/kcontrol/workspaceoptions/index.html. 

Some other affected KCM (probably not all):
* Workspace Behavior (https://docs.kde.org/trunk5/en/kde-workspace/kcontrol/workspaceoptions/index.html)
* Fonts (https://docs.kde.org/trunk5/en/kde-workspace/kcontrol/fonts/index.html)
* Language (https://docs.kde.org/trunk5/en/kde-workspace/kcontrol/translations/index.html)
* Launch Feedback (https://docs.kde.org/trunk5/en/kde-workspace/kcontrol/kcmlaunchfeedback/index.html)

OBSERVED RESULT
Deactivated help button

EXPECTED RESULT
Activated help button

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE tumbleweed 20181126
KDE Plasma Version: 5.14.3
KDE Frameworks Version: 5.52.0
Qt Version: 5.11.2

ADDITIONAL INFORMATION
Comment 1 carl 2018-12-09 17:47:54 UTC
Similar problem found, where some help button are activated but when clicked doesn't open anything (Touch screen swipe gestures) and I couldn't find doc about this module in the wiki.
Comment 2 Kai Uwe Broulik 2018-12-10 08:16:44 UTC
The KCMs do have a DocPath in their desktop files, so it's interesting that it works for Desktop Theme (which is the same QML KCM as the broken ones)
Comment 3 David Edmundson 2018-12-10 11:34:01 UTC
Git commit cc8545f9d2d5854b09f302aa93e2a7e2c89469a2 by David Edmundson.
Committed on 10/12/2018 at 11:33.
Pushed by davidedmundson into branch 'master'.

Add help button to KCMs where it was missing

Summary: BUG: 401932

Test Plan: Opened each

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17458

M  +1    -1    kcms/fonts/fonts.cpp
M  +1    -0    kcms/launch/package/contents/ui/main.qml
M  +1    -0    kcms/translations/package/contents/ui/main.qml
M  +3    -1    kcms/workspaceoptions/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/cc8545f9d2d5854b09f302aa93e2a7e2c89469a2