Bug 401924

Summary: build failure with qt-5.12.0
Product: [Frameworks and Libraries] frameworks-kwallet Reporter: Treeve Jelbert <treeve>
Component: generalAssignee: Valentin Rusu <valir>
Status: RESOLVED NOT A BUG    
Severity: normal CC: kdelibs-bugs-null, rdieter
Priority: NOR    
Version First Reported In: 5.53.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: compile log

Description Treeve Jelbert 2018-12-09 12:48:17 UTC
Created attachment 116803 [details]
compile log

SUMMARY
-- Build files have been written to: /usr/src/kwallet-5.53.0/build
[1/59] Generating ts...
[2/59] Automatic MOC for target kwalletbackend5
[3/59] Building CXX object src/runtime/kwalletd/backend/CMakeFiles/kwalletbackend5.dir/blockcipher.cc.o
[4/59] Building CXX object src/runtime/kwalletd/backend/CMakeFiles/kwalletbackend5.dir/blowfish.cc.o
../src/runtime/kwalletd/backend/blowfish.cc:138:5: warning: "Q_BYTE_ORDER" is not defined, evaluates to 0 [-Wundef]
 #if Q_BYTE_ORDER == Q_BIG_ENDIAN
     ^~~~~~~~~~~~
../src/runtime/kwalletd/backend/blowfish.cc:138:21: warning: "Q_BIG_ENDIAN" is not defined, evaluates to 0 [-Wundef]
 #if Q_BYTE_ORDER == Q_BIG_ENDIAN
                     ^~~~~~~~~~~~


full compile log attached
Comment 1 Christophe Marin 2018-12-09 15:33:29 UTC
Useful part of the log:
/usr/lib/gcc/x86_64-pc-linux-gnu/8.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: /opt/qt5/lib/libKF5Notifications.so.5.53.0: _edata: invalid version 21 (max 0)
/usr/lib/gcc/x86_64-pc-linux-gnu/8.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: /opt/qt5/lib/libKF5Notifications.so.5.53.0: error adding symbols: bad value
Comment 2 Treeve Jelbert 2018-12-09 18:01:11 UTC
this ws due to a bug in binutils. I patched binutils and rebuilt knotifications, at which point kwallet built successfully.

binutils commit 48e30f5238c70e738f44474d595c476ef4e4ec38