Bug 401832

Summary: Clicking non installed flatref package shows it's page with domain name and without additional info/screenshots
Product: [Applications] Discover Reporter: Alexander Mentyu <notuxius>
Component: Flatpak BackendAssignee: Aleix Pol <aleixpol>
Status: REOPENED ---    
Severity: normal CC: bugseforuns, jgrulich, katyaberezyaka, nate
Priority: NOR    
Version: 5.14.4   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Bug Depends on: 464206    
Bug Blocks:    
Attachments: Screenshot 1 with app domain name
Screenshot 2 with regular app name and screens

Description Alexander Mentyu 2018-12-06 19:46:17 UTC
STEPS TO REPRODUCE
1. Download any flatref file of not installed app - https://flathub.org/apps/details/com.valvesoftware.Steam
2. Open downloaded flatref file with Discover.

OBSERVED RESULT
App page with it's domain name and with incomplete info is displayed - screenshot 1

EXPECTED RESULT
Standard app page with normal name and screenshots is displayed - the page when selecting this app in Flathub source in Discover - screenshot 2

SOFTWARE/OS VERSIONS
Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.14.80
KDE Frameworks Version: 5.53.0
Qt Version: 5.11.2
Kernel Version: 4.15.0-42-generic
Comment 1 Alexander Mentyu 2018-12-06 19:47:01 UTC
Created attachment 116719 [details]
Screenshot 1 with app domain name
Comment 2 Alexander Mentyu 2018-12-06 19:47:33 UTC
Created attachment 116720 [details]
Screenshot 2 with regular app name and screens
Comment 3 Aleix Pol 2018-12-15 00:46:09 UTC
Git commit e3b49c448279209f26f3ea69772cf7cf6c36dbba by Aleix Pol.
Committed on 15/12/2018 at 00:44.
Pushed by apol into branch 'master'.

Fix opening flatpakref of already-existing repositories

Instead of loading it, which won't work, pick the resource that we already
have.

M  +11   -0    libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
M  +14   -0    libdiscover/backends/FlatpakBackend/FlatpakSourcesBackend.cpp
M  +1    -0    libdiscover/backends/FlatpakBackend/FlatpakSourcesBackend.h

https://commits.kde.org/discover/e3b49c448279209f26f3ea69772cf7cf6c36dbba
Comment 4 Patrick Silva 2019-02-23 21:16:21 UTC
Not fixed in Discover 5.15.1.
Discover asked for my password when I opened the flatpakref file (???).
After I enter my password, Discover shown a page with the same look as the first screenshot.

I tested Airtame
https://flathub.org/apps/details/com.airtame.Client
Comment 5 Nate Graham 2023-01-12 17:11:18 UTC
Tried to test this again today but it looks like opening local flatpakref files has regressed and is currently broken. :( See Bug 464206.