Bug 401793

Summary:	errors in breeze-dark SVG icons for text-x-* MIME types
Product:	[Plasma] Breeze	Reporter:	Laurent Bonnaud <L.Bonnaud>
Component:	Icons	Assignee:	visual-design
Status:	RESOLVED FIXED
Severity:	normal	CC:	kainz.a
Priority:	NOR
Version First Reported In:	5.14.4
Target Milestone:	---
Platform:	Kubuntu
OS:	Linux
Latest Commit:	https://commits.kde.org/breeze-icons/0eea3019324f276f248935c856700fdde7b847eb	Version Fixed In:	5.56
Sentry Crash Report:

Description Laurent Bonnaud 2018-12-05 19:54:37 UTC

SUMMARY

I see error messages about some SVG icons from the breeze dark theme.

STEPS TO REPRODUCE
0. Start dolphin from a terminal
1. In dolphin right click on some file
2. Click on "Properties"
3. Click on "File Type Options"
4. Click on the icon

OBSERVED RESULT

Error messages:

qt.svg: /usr/share/icons/breeze-dark/mimetypes/32/text-x-c++hdr.svg:109: Could not resolve property: a
qt.svg: /usr/share/icons/breeze-dark/mimetypes/32/text-x-c++hdr.svg:109: Could not resolve property: b
qt.svg: /usr/share/icons/breeze-dark/mimetypes/32/text-x-chdr.svg:102: Could not resolve property: b
qt.svg: /usr/share/icons/breeze-dark/mimetypes/32/text-x-chdr.svg:102: Could not resolve property: a
qt.svg: /usr/share/icons/breeze-dark/mimetypes/32/text-x-objchdr.svg:102: Could not resolve property: b
qt.svg: /usr/share/icons/breeze-dark/mimetypes/32/text-x-objchdr.svg:102: Could not resolve property: a

EXPECTED RESULT

no error message

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.52
Qt Version: 5.11.1

Comment 1 Noah Davis 2019-02-08 20:19:17 UTC

Git commit 0eea3019324f276f248935c856700fdde7b847eb by Noah Davis.
Committed on 08/02/2019 at 18:30.
Pushed by ndavis into branch 'master'.

Fix missing shadows on C/C++ header mimetype icons

Summary:
Some shadow objects had no fill because the gradients they referenced were missing.
FIXED-IN: 5.56

Reviewers: #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D18837

M  +15   -107  icons-dark/mimetypes/32/text-x-c++hdr.svg
M  +15   -100  icons-dark/mimetypes/32/text-x-chdr.svg
M  +15   -107  icons/mimetypes/32/text-x-c++hdr.svg
M  +15   -100  icons/mimetypes/32/text-x-chdr.svg

https://commits.kde.org/breeze-icons/0eea3019324f276f248935c856700fdde7b847eb