Bug 401792

Summary:	Flathub sources dropdown needs cleanup/optimization
Product:	[Applications] Discover	Reporter:	Alexander Mentyu <notuxius>
Component:	discover	Assignee:	Aleix Pol <aleixpol>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bugseforuns, nate
Priority:	NOR	Keywords:	usability
Version First Reported In:	5.14.4
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:	https://commits.kde.org/qqc2-desktop-style/afebad2e398d67f1a9cc6ef59cdc68a1dc83c154	Version Fixed/Implemented In:	5.54
Sentry Crash Report:
Attachments:	Dropdown screenshot 1 Dropdown screenshot 2

Description Alexander Mentyu 2018-12-05 19:27:15 UTC

STEPS TO REPRODUCE
1. Open Discover.
2. Select bottom left 'Sources' page.
3. Select 'Flathub' source in the list.
4. Select for example 'Krita' app in the flathub apps list.
5. Select top right 'Sources' dropdown.

OBSERVED RESULT
1. Hovering over 'flathub' dropdown option highlights only half of the dropdown option.
2. After selection of 'neon-bionic-main' dropdown option - both checkbox and radio button are displayed near the dropdown option.

SOFTWARE/OS VERSIONS
Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.14.80
KDE Frameworks Version: 5.53.0
Qt Version: 5.11.2
Kernel Version: 4.15.0-42-generic

Comment 1 Aleix Pol 2018-12-06 02:00:07 UTC

Can you upload a screenshot of what you mean?

Comment 2 Alexander Mentyu 2018-12-06 19:12:53 UTC

Created attachment 116717 [details]
Dropdown screenshot 1

Comment 3 Alexander Mentyu 2018-12-06 19:13:49 UTC

Created attachment 116718 [details]
Dropdown screenshot 2

Comment 4 Aleix Pol 2018-12-10 15:51:19 UTC

Git commit afebad2e398d67f1a9cc6ef59cdc68a1dc83c154 by Aleix Pol.
Committed on 10/12/2018 at 15:49.
Pushed by apol into branch 'master'.

Fix menu item width when the delegate is overriden

Summary:
Have MenuItem get the width of the parent instead of needing to specify it
every time.
This fixes an issue where MenuItem is used from Kirigami.ActionsMenuItem where
it would sometimes not take the whole width. See bug.

Reviewers: #kirigami, mart

Reviewed By: #kirigami, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17484

M  +1    -1    org.kde.desktop/Menu.qml
M  +2    -0    org.kde.desktop/MenuItem.qml

https://commits.kde.org/qqc2-desktop-style/afebad2e398d67f1a9cc6ef59cdc68a1dc83c154

Comment 5 Nate Graham 2018-12-11 14:58:29 UTC

*** Bug 400905 has been marked as a duplicate of this bug. ***