Summary: | [feature] - show app number overlay earlier | ||
---|---|---|---|
Product: | [Plasma] lattedock | Reporter: | Tinu <martin.bachtold> |
Component: | application | Assignee: | Michail Vourlakos <mvourlakos> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | martin.bachtold, mgraesslin, trmdi |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=370454 | ||
Latest Commit: | https://commits.kde.org/latte-dock/6f1c66f7d20283dc6fec4ff56fc682d75bf69eb2 | Version Fixed In: |
Description
Tinu
2018-12-05 13:50:55 UTC
You can use Meta+' for showing numbers for what you are requesting can be only X11 specific and I don't think a solution exists, Feel free of course for anyone to play with this and send any patch for review... You can use Meta+' for showing numbers for what you are requesting can be only X11 specific and I don't think a solution exists, Feel free of course for anyone to play with this and send any patch for review... Is there any way to display shortcut badges while holding the Meta button? Because when users are holding it, that means they arr not remembering what the needed key is, Latte should display badges in that case to guide them. Press Meta+` is a bit inconvenient. (In reply to trmdi from comment #3) > Is there any way to display shortcut badges while holding the Meta button? I thought this was not possible but now I remembered that global menu plasmoid is showing underscores when Alt is hold down. I can check if this could some how enabled also for Meta. (In reply to trmdi from comment #3) > Is there any way to display shortcut badges while holding the Meta button? ok not possible, this is achieved through : PlasmaCore.DataSource { id: keystateSource engine: "keystate" connectedSources: ["Alt"] } in global menu plasmoid. For Meta is does not work. Hmm, we should ask @mgraesslin because he is a Kwin master. I guess it relates to Kwin. Is it possible? Unity can do it, why can't KDE do? (In reply to trmdi from comment #7) > Unity can do it, why can't KDE do? asking plasma devs how this could be achieved both for X11 and wayland is a good idea (In reply to trmdi from comment #6) > Hmm, we should ask @mgraesslin because he is a Kwin master. I guess it > relates to Kwin. Is it possible? I'm sorry, but I don't understand what this bug report is about. (In reply to Martin Flöser from comment #9) > I'm sorry, but I don't understand what this bug report is about. Thanks for your reply. The question is: Can we make the thing Unity did? Catch the Meta/Super/Win key holding event from Latte dock? I have no idea what unity did, I have no idea what Latte does. Please explain things so that someone not knowing the feature can understand. (In reply to Martin Flöser from comment #11) > I have no idea what unity did, I have no idea what Latte does. Please > explain things so that someone not knowing the feature can understand. Sorry, I meant, we want to detect when the user holds the Meta key in about x seconds (and when he releases the key afterwards). Is it possible? Could you please suggest some idea? It's possible on X11, it's impossible on Wayland without support from KWin. On X11 it's a mess and I strongly advise against trying to do anything about it. KWin has detection on X11 for when Meta is pressed, but the code is still not correct - after years. (In reply to Martin Flöser from comment #13) > It's possible on X11, it's impossible on Wayland without support from KWin. > On X11 it's a mess and I strongly advise against trying to do anything about > it. KWin has detection on X11 for when Meta is pressed, but the code is > still not correct - after years. yeah I agree, I do not also like X11-only-centric solutions. Plasma is using an approach for this when is trying to catch the Alt key pressing, the following code is found in the Global menu plasmoid: PlasmaCore.DataSource { id: keystateSource engine: "keystate" connectedSources: ["Alt"] } I suppose that this should not work under wayland... Best approach for this is: 1. make engine: "keystate" to support "Meta" under X11 2. make engine: "keystate" to support this also under wayland probably through kwin. The KeyState datasource is using KModifierKeyInfo internally. This class is currently not yet ported to Wayland and can - in it's current way - not support Wayland. On Wayland modifier state is only sent to the application having the keyboard focus. For something like Latte this is no solution, you normally don't have keyboard focus. KModifierKeyInfo will still work for many other things in applications, but not for things like global listening. Please note that I doubt that this class handles all corner cases correctly (as that's impossible) on X11. as discussed this should be handled first upstream in order to reach in a state that Latte can support it (In reply to Michail Vourlakos from comment #5) > (In reply to trmdi from comment #3) > > Is there any way to display shortcut badges while holding the Meta button? > > ok not possible, this is achieved through : > > PlasmaCore.DataSource { > id: keystateSource > engine: "keystate" > connectedSources: ["Alt"] > } > > in global menu plasmoid. For Meta is does not work. If you change these lines like this, it works: 102 -> connectedSources: ["Super"] 118 -> var alt = keystateSource.data.Super; Can you apply it in Latte ? (In reply to trmdi from comment #17) > (In reply to Michail Vourlakos from comment #5) > > (In reply to trmdi from comment #3) > > > Is there any way to display shortcut badges while holding the Meta button? > > > > ok not possible, this is achieved through : > > > > PlasmaCore.DataSource { > > id: keystateSource > > engine: "keystate" > > connectedSources: ["Alt"] > > } > > > > in global menu plasmoid. For Meta is does not work. > > If you change these lines like this, it works: > > 102 -> connectedSources: ["Super"] > 118 -> var alt = keystateSource.data.Super; > > Can you apply it in Latte ? It needs to be in c++, the responsible class is globalshortcuts.cpp and needs to be considered how to not break, Meta activates the application launcher,. I could accept any help for this Git commit 6f1c66f7d20283dc6fec4ff56fc682d75bf69eb2 by Michail Vourlakos. Committed on 01/02/2019 at 17:14. Pushed by mvourlakos into branch 'master'. Display shortcut badges while holding Super Summary: Use `KModifierKeyInfo` to display shortcut badges while holding Super Test Plan: Just playing with it. I still don't understand the `GlobalShortcut` class very well, correct me if I make any mistake. Reviewers: #latte_dock, mvourlakos Reviewed By: #latte_dock, mvourlakos Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D18620 M +1 -1 CMakeLists.txt M +1 -0 README.md M +1 -0 app/CMakeLists.txt M +17 -0 app/globalshortcuts.cpp M +6 -0 app/globalshortcuts.h https://commits.kde.org/latte-dock/6f1c66f7d20283dc6fec4ff56fc682d75bf69eb2 |