Bug 401656

Sorry, I have just re-checked and now it works well. Probably there were too many applications open the first time. I apologize for the confusion. (krita-4.2.0-pre-alpha-4fb7b5b-x86_64.appimage)

Created attachment 116822 [details]
(New video)

I've finally found that it happens only with objects coming from layers that have been duplicated, while the "Select Shapes Tool" was active/selected (see new video).

The exact steps are:

    1. CTRL + N (create new)
    2. create some vectors on 1 layer
    3. switch to the "Select Shapes Tool" (important!)
    4. duplicate the vector layer.

Actual Results: it won't be possible to arrange the duplicated objects.

Reopening...

I have reproduced the issue. Another way to reproduce is to:

1, create a file with a vector layer, two shapes
2, save and close the file
3, reopen the file
4, try to align the shapes
5, nothing happens.

I'm attaching my testing file to this bug.

The bug is not specific to the Arrange docker. The right-click context menu is also affected.


I have run it in GDB, here is what I have seen:

After selecting my two shapes in Krita, the following function (in DefaultTool.cpp:1573) is triggered:

void DefaultTool::updateActions()
{
    QList<KoShape*> editableShapes;

    if (koSelection()) {
        editableShapes = koSelection()->selectedEditableShapes();
    }
[ ... code that enables/disables arrange actions ... ]

It runs two times. Usually the first time it calls DefaultTool::koSelection, which returns two entries for editableShapes and therefore the arrange actions are enabled.

The second time, ToolReferenceImages::koSelection() is called instead, editableShapes are therefore empty and the arrange actions are disabled.

Created attachment 116925 [details]
KRA file for testing

Created attachment 116926 [details]
a backtrace of the second run of DefaultTool::updateActions()

Git commit 325cbf6c62d3d83fc7929f0eddd8313429030214 by Anna Medonosova.
Committed on 19/12/2018 at 13:08.
Pushed by amedonosova into branch 'master'.

Partial fix for bug 401656

Summary:
Only Default Tool should connect to the selectedShapesProxy::selectionChanged,
otherwise arrange actions (both in context menu and arrange docker) get disabled
errorneusly.

This fixes just one part of the bug. The issue with disabled arrange
actions after layer duplication is still present.

Reviewers: #krita, rempt

Reviewed By: #krita, rempt

Tags: #krita

Differential Revision: https://phabricator.kde.org/D17665

M  +4    -2    plugins/tools/defaulttool/defaulttool/DefaultTool.cpp
M  +1    -1    plugins/tools/defaulttool/defaulttool/DefaultTool.h
M  +1    -1    plugins/tools/defaulttool/defaulttool/DefaultToolFactory.cpp
M  +1    -1    plugins/tools/defaulttool/referenceimagestool/ToolReferenceImages.cpp

https://commits.kde.org/krita/325cbf6c62d3d83fc7929f0eddd8313429030214

The issue with duplicate layer is still present. From what I have seen in the debugger, after I duplicate the layer, KoSelection stops emitting the selectionChanged signal. If I switch to another layer and back, it starts sending the signal again, if I switch to another tool and back, it also starts sending the signal.

With latest git master/appimage I cannot reproduce this bug anymore. Please, mvowada, can you confirm that it is indeed working now?

I also cannot reproduce with the Krita 4.2.3. I thought there were some fixes Dmitry did somewhat recently with fixing some of the signals and connections when duplicating vector shapes.

I am going to switch this back to needs info for now.

(In reply to Anna Medonosova from comment #9)
> With latest git master/appimage I cannot reproduce this bug anymore. Please,
> mvowada, can you confirm that it is indeed working now?

Hi Anna, I'm sorry but I'm not able to try with a more recent version of Krita since the appimage now uses Qt 5.12 and it won't start on my old OS. If the bug is fixed now, please, feel free to close this ticket. Thanks

Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.

All issues from this bug are fixed now.