Bug 401582

Summary: Rubber-band selecting one item from its metadata column and shift-clicking another item does not include the items between them in the selection
Product: [Applications] dolphin Reporter: pietz
Component: view-engine: details modeAssignee: Dolphin Bug Assignee <dolphin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: akselmo, alexis.gm, nate, pietz
Priority: NOR Keywords: usability
Version First Reported In: 18.04.3   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Steps how to reproduce the wrong behavior

Description pietz 2018-11-30 17:16:45 UTC
SUMMARY

In other view modes it works as expected.

STEPS TO REPRODUCE
1. Mark a file
2. Go down with your mouse over a few files (more than 2 or 3) then SHIFT click the file to select ALL files in between
3. Dolphin only marks the first selected and the second selected
4. Go up again to the previously selected file and SHIFT click the file below
5. No all files in between are marked

OBSERVED RESULT
SHIFT click doesn't work

EXPECTED RESULT
SHIFT clik should mark all files in between (The first selected an all until the SHIFT click file)

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: YES
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Nate Graham 2018-12-13 23:30:15 UTC
Cannot reproduce with Dolphin 18.08, 18.12, or from git master. What version are you using? Do you use double-click or single-click?
Comment 2 pietz 2018-12-14 08:23:15 UTC
At home I use 18.04.3 as mentioned in the Bug. At work I use 17.12.3 and it is the same behavior.

Don't use a double click. Only single clicks as I mentioned in my description and donn't draw a rectangle (this works).
Comment 3 Nate Graham 2018-12-15 21:59:30 UTC
Still cannot reproduce on Kubuntu 18.10, Manjaro, or KDE Neon. Assuming it's been fixed in a later version. Please re-open if you can reproduce the issue in Dolphin 18.12 or later. Thanks!
Comment 4 pietz 2019-06-07 14:37:06 UTC
It is still present in Dolphin 18.12. Maybe some more ideas:

The first item is NOT clicked with Shift pressed. Only swipe your mouse in from the right side to mark it with the lasso effect.

Then go down with your mouse a few items and SHIFT+CLICK.

In my case only the first and the last are selected. When I use Shift in the first time, it works as expected.
Comment 5 Nate Graham 2019-06-07 15:05:33 UTC
(In reply to pietz from comment #4)
> It is still present in Dolphin 18.12. Maybe some more ideas:
> 
> The first item is NOT clicked with Shift pressed. Only swipe your mouse in
> from the right side to mark it with the lasso effect.

I'm not sure what this means. The first file must be selected, or else it won't work.

Maybe a screen recording would be helpful.
Comment 6 Bug Janitor Service 2019-06-22 04:33:07 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 pietz 2019-06-26 16:26:00 UTC
Created attachment 121171 [details]
Steps how to reproduce the wrong behavior

Sorry for my late reply. Now I tried to explain it in a small PDF. Can you now reproduce or need more information?

Sure I will help you as long as this annoying bug is solved :-)

Thanks a lot
Andreas
Comment 8 pietz 2019-06-26 17:06:11 UTC
I don't know what to do after NEEDSINFO and after I delivered the requested information. So I set it to REOPENED. Is this correct?
Comment 9 Nate Graham 2019-07-08 14:09:21 UTC
So basically, to reproduce, you go into details mode, select an item by drawing a rubber-band rectangle around one of its metadata columns (not the item itself) and then shift-click on an item somewhere else. The in-between items do not get selected.

Everything works properly if your initial rubber-band selection touches the items themselves rather than their metadata columns.
Comment 10 pietz 2019-07-08 14:17:00 UTC
Oh yeah. You are right. When your first selection touches the filename it works as expected. But this only happens randomly because you are often just in the area around. It looks the same for your eyes.

So you can reproduce it now? Finally? :-D
Comment 11 Nate Graham 2019-07-09 00:25:41 UTC
Yep. :)
Comment 12 Nate Graham 2019-07-11 02:32:14 UTC
The bug is probably somewhere in kitemlistcontroller.cpp, maybe in slotRubberBandChanged()

https://cgit.kde.org/dolphin.git/tree/src/kitemviews/kitemlistcontroller.cpp#n1097
Comment 13 alexis.gm 2019-09-23 02:27:36 UTC
I'm glad someone else made this bug report.  I've experienced this bug for the past 5 to 10 years, on every single distro that I've tried.  For example, I just tried it on:

- Kubuntu 19.04
- PopOS 18.10 (not a KDE DE, but I installed dolphin anyway).
- Up-to-date KDE Neon

It doesn't just affect one machine.  It's the same on all the different computers I've used (at least 4 different machines: dell laptop, lenovo thinkpad, home built desktop, dell work computer).  

This is the single most frustrating bug that I've encountered.  It affects my user experience every single day.
Comment 14 alexis.gm 2019-09-23 02:30:15 UTC
(In reply to pietz from comment #10)
> Oh yeah. You are right. When your first selection touches the filename it
> works as expected. But this only happens randomly because you are often just
> in the area around. It looks the same for your eyes.
> 
> So you can reproduce it now? Finally? :-D

I never noticed this!  Thank you for pointing this out.  At least I have a good workaround now: make sure that my initial selection touches the file name.