Bug 401529

Summary: kdesvn commit message window should use plain-text, occasionally sends truncated commit message to svnclient
Product: [Applications] kdesvn Reporter: Maciej Mrozowski <reavertm>
Component: GeneralAssignee: KDESvn default assignee <kdesvn-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: GIT (master)   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: https://commits.kde.org/kdesvn/d95fadbb28a19e467dad1185722fc688f1c966b6 Version Fixed/Implemented In:
Sentry Crash Report:

Description Maciej Mrozowski 2018-11-29 11:40:04 UTC 
SUMMARY

Commit message window behaves like Rich-Text edit box. It's evident when pasting  text from other tools (like issue subjects from Jira). This has some other side effect. Those additional formatting characters sometimes even terminate the input and not full text (from commit message window) is sent to svn command, just the first line (where some invisible characters were interpreted as end-of-input.

The solution I understand is to force kdesvn commit message window to use plain-text container that automatically converts any clipboard contents to plain-text.

IT's perhaps regression. Similar problem has been addressed before: https://bugs.kde.org/show_bug.cgi?id=230612


STEPS TO REPRODUCE
1. Open kdesvn commit message window
2. Copy some text from web browser and paste to already open kdesvn commit message window
3. Optionally type some text in new lines in kdesvn commit message window

OBSERVED RESULT

Formatting or copied text is retained. Additionally, depending on copied text, if it contains newlines (<br>?), it might prematurely terminate commit message text: lines typed in step 3 might not end up being sent to svnclient.

EXPECTED RESULT

Any formatting from pasted text should be removed. All text from commit message window should be sent to svnclient.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Fedora 29
(available in About System)
KDE Plasma Version: 5.14.4
KDE Frameworks Version: 5.52.0
Qt Version: 5.11.1

ADDITIONAL INFORMATION
kdesvn-1.7.0-6.fc29.x86_64
Comment 1 Christian Ehrlicher 2019-05-28 19:32:01 UTC 
Git commit d95fadbb28a19e467dad1185722fc688f1c966b6 by Christian Ehrlicher.
Committed on 28/05/2019 at 18:59.
Pushed by chehrlic into branch 'master'.

Don't accept richtext in commit message dialog

M  +5    -9    src/ksvnwidgets/commitmessage.ui
M  +11   -7    src/svnfrontend/editpropsdlg.ui

https://commits.kde.org/kdesvn/d95fadbb28a19e467dad1185722fc688f1c966b6