| Summary: | src/libs/ui/kptdependencyeditor.cpp:1338]: (style) Same expression on both sides of '&&'. | ||
|---|---|---|---|
| Product: | [Applications] calligraplan | Reporter: | dcb314 |
| Component: | general | Assignee: | Dag Andersen <dag.andersen> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | 3.1.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/calligraplan/f7c10594066d561453a12cff81506ca0d49c9cba | Version Fixed/Implemented In: | 3.1.89 |
| Sentry Crash Report: | |||
Yep, the three cases need use both 'c1' and 'c2' consistently. But I am not sure if the order should be 'c1' 'c2' as in the switch block at line 1301, or swapped to 'c2' 'c1' because the preceeding 'if' seems to detect a reverse case. I was about to mark as a junior job, but I guess only calligraplan developers can decide which way is correct. Git commit f7c10594066d561453a12cff81506ca0d49c9cba by Dag Andersen. Committed on 20/12/2018 at 07:48. Pushed by danders into branch 'master'. Fix incorrect if statements in dependency editor FIXED-IN: 3.1.89 M +2 -2 src/libs/ui/kptdependencyeditor.cpp https://commits.kde.org/calligraplan/f7c10594066d561453a12cff81506ca0d49c9cba |
SUMMARY Source code is if ( c1->ctype() == DependencyNodeItem::Finish && c1->ctype() == DependencyNodeItem::Finish ) { STEPS TO REPRODUCE 1. 2. 3. OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: MacOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION