Bug 401464

Summary: Activities + icons
Product: [Plasma] plasmashell Reporter: Oleg Solovyov <mcpain>
Component: Desktop ContainmentAssignee: Sebastian Kügler <sebas>
Status: RESOLVED FIXED    
Severity: normal CC: plasma-bugs
Priority: NOR    
Version: 5.14.3   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/plasma-desktop/dcb4c158b41452d18e629b30b472b6d3294070ef Version Fixed In:
Attachments: Video
Bug video

Description Oleg Solovyov 2018-11-27 13:11:50 UTC 
SUMMARY
I have dual-monitor set and there are some problems with switching between activities

STEPS TO REPRODUCE
0. Create user and log in
1. Create an activity
2. Do something (move, copy or delete icons)
3. Switch to activity we created at step 1
4. The icons are duplicated on second screen
5. Do something (move, copy or delete icons, the duplicated icons will disappear)
6. Switch back to default activity
7. The icons are duplicated again

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 4.14.80
(available in About System)
KDE Plasma Version: 5.14.3 (also reproduces on 5.12.7)
KDE Frameworks Version: 5.49.0
Qt Version: 5.9.6
Comment 1 Oleg Solovyov 2019-01-24 08:03:44 UTC 
Created attachment 117627 [details]
Video
Comment 2 Oleg Solovyov 2019-01-24 08:37:45 UTC 
Created attachment 117630 [details]
Bug video
Comment 3 Oleg Solovyov 2019-02-05 07:30:58 UTC 
Found a clue:

FolderModel::filterAcceptsRow - (m_screen == 1) branch is missing
just adding
+ return false;
is not the solution, we need to have an additional statement there but I still have not figured out it
Comment 4 Oleg Solovyov 2019-02-13 12:12:59 UTC 
https://phabricator.kde.org/D18979

Figured it out
Comment 5 Eike Hein 2019-04-02 09:50:28 UTC 
Git commit dcb4c158b41452d18e629b30b472b6d3294070ef by Eike Hein, on behalf of Oleg Solovyov.
Committed on 02/04/2019 at 09:49.
Pushed by hein into branch 'master'.

foldermodel: store information about screen used

Summary:

According to FolderModel::filterAcceptsRow code, it is possible that folderview is used by containment but not associated with a screen.
In case of m_screen == -1 there was no information about which items we should filter out.

Instead, we do not change m_screen to -1 and we can filter out items that does not belong to our screen.
m_screenUsed shows whether folderview is associated with a screen or not

Reviewers: broulik, hein, #plasma

Reviewed By: hein, #plasma

Subscribers: cfeck, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18979

M  +15   -14   containments/desktop/plugins/folder/foldermodel.cpp
M  +1    -0    containments/desktop/plugins/folder/foldermodel.h

https://commits.kde.org/plasma-desktop/dcb4c158b41452d18e629b30b472b6d3294070ef