Bug 401463

Created attachment 116532 [details]
Current rendering of borders in mc in konsole

If I start xterm and run mc inside xterm, then borders are rendered in nice straight lines as before.

Same for gnome-terminal - run mc inside gnome-terminal, borders are rendered in nice straight lines as before.

I can reproduce this here (similar system).

Enabling the option "Use line characters contained in font" in the profile settings ("Appearance") fixes it for me.

PS: it's caused by https://cgit.kde.org/konsole.git/commit/?id=ed5fa1f855a05ba82fe4f2f6d3ead803aa5eefdb (fix for bug 397985).

Reverting that commit fixes it with "Use line characters contained in font" off, but that causes rounded corners look ugly again of course... :-/

Enabling the option "Use line characters contained in font" in the profile settings ("Appearance") fixes only horizontal border lines, vertical border lines still have gaps in them. 

So, IMO, this is not a proper fix.

(In reply to Vadym Krevs from comment #6)
> Enabling the option "Use line characters contained in font" in the profile
> settings ("Appearance") fixes only horizontal border lines, vertical border
> lines still have gaps in them. 
> 
> So, IMO, this is not a proper fix.

I didn't say it's a proper fix (maybe an acceptable workaround though), but I thought it should help to find where the problem lies. ;-)

If there are gaps in vertical border lines, that's a different problem IMHO, and maybe one of the reasons why konsole actually draws those lines itself by default instead of using the font's characters.

Btw, I don't see those gaps here, but that may have various reasons. (e.g. the font used or its size, screen scaling, ...)

I use Ubuntu Mono, size 12 in Konsole. Also, reverting the commit mentioned in comment 5 does restore border lines to expected appearance.

fixed with https://phabricator.kde.org/D16947

and https://phabricator.kde.org/D17294 should make it look even better (well, not the borders).

Git commit 14b3c8be2c15ed9711b1308b4a991de4aad5802d by Kurt Hindenburg, on behalf of Martin T. H. Sandsmark.
Committed on 06/12/2018 at 15:26.
Pushed by hindenburg into branch 'master'.

fix drawing box chars, avoid storing and saving state all the time

Summary:
to get the box chars to be drawn correctly we need to turn on high
quality antialiasing in qpainter. in addition only turn it on if
antialiasing is enabled.

lastly qpainter.save()/restore() is called very often, so try to avoid
that if it isn't necessary.

Test Plan:
`cat tests/boxes.txt`

old:

{F6428268}

new:

{F6450304}

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: wbauer, konsole-devel, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D16947

M  +20   -25   src/TerminalDisplay.cpp

https://commits.kde.org/konsole/14b3c8be2c15ed9711b1308b4a991de4aad5802d

Installed updated konsole packages from openSuse's OBS and can confirm the issue is fixed.

*** Bug 402135 has been marked as a duplicate of this bug. ***

*** Bug 402230 has been marked as a duplicate of this bug. ***

Git commit 807ac77061604c2ac7cf84b0a0b29dd949a6c634 by Kurt Hindenburg, on behalf of Martin T. H. Sandsmark.
Committed on 21/12/2018 at 16:05.
Pushed by hindenburg into branch 'Applications/18.12'.

fix drawing box chars, avoid storing and saving state all the time

Summary:
to get the box chars to be drawn correctly we need to turn on high
quality antialiasing in qpainter. in addition only turn it on if
antialiasing is enabled.

lastly qpainter.save()/restore() is called very often, so try to avoid
that if it isn't necessary.

Test Plan:
`cat tests/boxes.txt`

old:

{F6428268}

new:

{F6450304}

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: wbauer, konsole-devel, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D16947

(cherry picked from commit 14b3c8be2c15ed9711b1308b4a991de4aad5802d)

M  +20   -25   src/TerminalDisplay.cpp

https://commits.kde.org/konsole/807ac77061604c2ac7cf84b0a0b29dd949a6c634

Created attachment 117582 [details]
Alsamixer in konsole master

It looks like the fix is incomplete - it does not work for bold lines, like those visible in alsamixer.

(In reply to Fabian Vogt from comment #15)
> It looks like the fix is incomplete - it does not work for bold lines, like
> those visible in alsamixer.

That'S already reported as bug#402415 though.

(In reply to Wolfgang Bauer from comment #16)
> (In reply to Fabian Vogt from comment #15)
> > It looks like the fix is incomplete - it does not work for bold lines, like
> > those visible in alsamixer.
> 
> That'S already reported as bug#402415 though.

Closing as FIXED again therefore.