Bug 401454

Summary: Add a --show-percs option to cg_annotate and callgrind_annotate.
Product: [Developer tools] valgrind Reporter: Nick Nethercote <n.nethercote>
Component: cachegrindAssignee: Nicholas Nethercote <njn>
Status: RESOLVED FIXED    
Severity: normal CC: philippe.waroquiers
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: patch

Description Nick Nethercote 2018-11-27 04:08:47 UTC 
Created attachment 116523 [details]
patch

Add a --show-percs option to cg_annotate and callgrind_annotate.
   
Because it's very useful. As part of this, the "percentage of events
annotated" numbers at the bottom of the output is changed to "events
annotated" so that --show-percs doesn't compute a percentage of a
percentage.
    
Example output lines:

> 4,967,137,442 (100.0%)  PROGRAM TOTALS
>     
> 4,543 (25.23%)    17,566 ( 0.43%)    47,993 ( 0.92%) /build/glibc-OTsEL5/glibc-2.27/elf/dl-lookup.c
>     
> 1 ( 0.01%) 2,000,001 (49.29%) 3,000,004 (57.36%)     for (int i = 0; i < 1000000; i++) {

The commit also adds some much-needed tests for cg_annotate and
callgrind_annotate.
Comment 1 Nick Nethercote 2018-12-05 13:21:00 UTC 
I don't think this will be a controversial change, given that it doesn't change default behaviours. I will land it early next week if there are no objections in the meantime.