Bug 401415

Summary: Parsing errors with SMS messages
Product: [Applications] kdeconnect Reporter: Douglas Summers <ajgringo619>
Component: commonAssignee: Albert Vaca Cintora <albertvaka>
Status: RESOLVED WORKSFORME    
Severity: normal CC: simon
Priority: NOR    
Version First Reported In: 1.3.3   
Target Milestone: ---   
Platform: Mint (Debian based)   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Text Message Window
SMS Notifications

Description Douglas Summers 2018-11-26 03:56:01 UTC
SUMMARY
Whenever I get a new SMS message, the window seems to have trouble with the break <br> between the sender and the message. I am also getting duplicate popups for each message; this is only on SMS messages, regular phone notifications are working fine.

STEPS TO REPRODUCE
1. Send test message
2. Sender and message are displayed like this: Sender<br>message
3. 

OBSERVED RESULT
No separation between the sender and the actual message

EXPECTED RESULT
Clear distinction between sender and message body

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: Mint 19 XFCE
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Here is an example error message:
Nov 25 19:29:15 xfce4-notifyd[2043]: Failed to set text 'SMS from me<br>Testing from my computer' from markup due to error parsing markup: Error on line 1 char 66: Element 'markup' was closed, but the currently open element is 'br'
Comment 1 Simon Redman 2018-11-26 15:23:18 UTC
Could you please attach a screenshot? I don't fully understand what elements you are referring to.

Duplicate SMS messages is another issue, due to both the Notifications plugin and SMS plugin handling SMS messages. You could disable the SMS plugin for now, since it has no other use until the messaging app is released
Comment 2 Douglas Summers 2018-11-26 18:30:39 UTC
Created attachment 116511 [details]
Text Message Window

How do you disable the SMS plugin? I tried to hide notifications via the xfce4-notify plugin, but that didn't work.
Comment 3 Simon Redman 2018-11-26 18:38:06 UTC
(In reply to Douglas Summers from comment #2)
> Created attachment 116511 [details]
> Text Message Window
Am I correct that what is shown there is an XFCE notification? The connected error message is pretty strange. I wouldn't expect <br> to need a closing </br>. I don't know if that's something KDE Connect can handle, or whether that is an XFCE bug

> How do you disable the SMS plugin? I tried to hide notifications via the
> xfce4-notify plugin, but that didn't work.
You can disable it either on the phone or in the desktop configuration applet. I have personally never used KDE Connect with XFCE, so I don't know what the applet looks like in that case. On the phone, simply click on your desktop in the Connected Devices section, then open the three-dot menu, select Plugin Settings, and disable the "Send SMS" plugin. (I guess that ought to be renamed to send and receive!)
Comment 4 Douglas Summers 2018-11-26 18:46:00 UTC
I disabled the phone plugin, which killed the KDE Connect messages, but the XFCE messages still come up (only got 5 this time!). I even turned off 'Receive Notifications' from the desktop app and I still get SMS messages (via the XFCE plugin).

What I don't understand is why this only affects the SMS message notifications and not the rest of my apps.
Comment 6 Douglas Summers 2018-11-26 19:03:52 UTC
One more thing I just noticed. The KDE Connect messages are clean, but the xfce4-notify messages allow me to reply (which works).
Comment 7 Nicolás Alvarez 2018-11-26 21:52:57 UTC
I hid your comment because it publicly showed your phone number.
Comment 8 Nicolás Alvarez 2018-11-26 21:53:41 UTC
Re-posting Comment 5:

Here's a sample log entry for the xfce4-notifyd plugin:

[2018-11-26T10:53:44]
app_name=KDE Connect
summary=ZTE
body=SMS from +1xxxxxxxxxx<br>Testing from my computer
app_icon=mail-receive
expire-timeout=0
action-id-0=1
action-label-0=Reply

It seems like KDE Connect messages are correct, but for some odd reason the xfce4 plugin can't handle them. Hopefully I can find a way to disable them as they'll just dupes.
Comment 9 Douglas Summers 2018-11-26 21:56:27 UTC
(In reply to Nicolás Alvarez from comment #7)
> I hid your comment because it publicly showed your phone number.

Thank you very much. Is there a way for me to edit/delete this comment?
Comment 10 Nicolás Alvarez 2018-11-26 21:59:54 UTC
I already made it private, so only Bugzilla admins can see it.
Comment 11 Simon Redman 2018-11-27 17:23:50 UTC
(In reply to Douglas Summers from comment #6)
> One more thing I just noticed. The KDE Connect messages are clean, but the
> xfce4-notify messages allow me to reply (which works).

Of course, all messages involving forwarding from the phone are created by KDE Connect. Could you attach a screenshot of the other element you are indicating, the one which you describe as "clean"?
Comment 12 Douglas Summers 2018-11-27 17:46:13 UTC
Created attachment 116539 [details]
SMS Notifications
Comment 13 Nicolás Alvarez 2018-11-28 01:51:48 UTC
The content of attachment 116511 [details] has been deleted for the following reason:

contains personal phone number
Comment 14 Justin Zobel 2023-01-18 02:40:51 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 15 Bug Janitor Service 2023-02-02 05:01:31 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 16 Bug Janitor Service 2023-02-17 03:49:01 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!