| Summary: | Kmail crashes on hitting reply to email/new email | ||
|---|---|---|---|
| Product: | [Applications] kontact | Reporter: | Bret J. Savino <bret> |
| Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | list, montel, winter |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/messagelib/32bbd45cdbbb8c60105ced80debab1eb6ed40226 | Version Fixed In: | 18.12.0 |
| Sentry Crash Report: | |||
|
Description
Bret J. Savino
2018-11-23 15:26:15 UTC
ditto. happening recently with a self-built version from master against Fedora28 provided Qt5.11.1 makes kmail unusable forgot to mention that "New Message" also crashes with the same bt Here is my hack to get kmail working again (I doubt this is a kmail bug -- more likely a QWebEngine bug). Be warned: you will see memory leaks with this patch.
iff --git a/templateparser/src/templateparserextracthtmlinfo.cpp b/templateparser/src/templateparserextracthtmlinfo.cpp
index 72dddbdc..2f7c59e8 100644
--- a/templateparser/src/templateparserextracthtmlinfo.cpp
+++ b/templateparser/src/templateparserextracthtmlinfo.cpp
@@ -31,8 +31,8 @@ TemplateParserExtractHtmlInfo::TemplateParserExtractHtmlInfo(QObject *parent)
TemplateParserExtractHtmlInfo::~TemplateParserExtractHtmlInfo()
{
- delete mTemplateWebEngineView;
- delete mExtractHtmlElementWebEngineView;
+ //delete mTemplateWebEngineView;
+ //delete mExtractHtmlElementWebEngineView;
}
void TemplateParserExtractHtmlInfo::setHtmlForExtractingTextPlain(const QString &html)
Same here (on the new mail crash). I wish i could understand your patch, mine was Kubuntu 18.10 on a separate partition. The new mesa looks awesome on an external. Kmail has such potential, this is the second major bug in as many months with Neon. Not complaining but maybe I juwt cant hack Neon. (In reply to Allen Winter from comment #3) > Here is my hack to get kmail working again (I doubt this is a kmail bug -- > more likely a QWebEngine bug). Be warned: you will see memory leaks with > this patch. > > iff --git a/templateparser/src/templateparserextracthtmlinfo.cpp > b/templateparser/src/templateparserextracthtmlinfo.cpp > index 72dddbdc..2f7c59e8 100644 > --- a/templateparser/src/templateparserextracthtmlinfo.cpp > +++ b/templateparser/src/templateparserextracthtmlinfo.cpp > @@ -31,8 +31,8 @@ > TemplateParserExtractHtmlInfo::TemplateParserExtractHtmlInfo(QObject *parent) > > TemplateParserExtractHtmlInfo::~TemplateParserExtractHtmlInfo() > { > - delete mTemplateWebEngineView; > - delete mExtractHtmlElementWebEngineView; > + //delete mTemplateWebEngineView; > + //delete mExtractHtmlElementWebEngineView; > } > > void TemplateParserExtractHtmlInfo::setHtmlForExtractingTextPlain(const > QString &html) For sure a mem leak => it's not a good patch for source. did you try a deleteLater() ? right. my hack was just desperation. I tried the deleteLater() solution with Laurent's help and it seems to work fine. I will commit. Git commit 32bbd45cdbbb8c60105ced80debab1eb6ed40226 by Allen Winter. Committed on 29/11/2018 at 14:21. Pushed by winterz into branch 'Applications/18.12'. templateparserextracthtmlinfo.cpp - deleteLater in dtor ack'd by Laurent FIXED-IN: 18.12.0 M +2 -2 templateparser/src/templateparserextracthtmlinfo.cpp https://commits.kde.org/messagelib/32bbd45cdbbb8c60105ced80debab1eb6ed40226 Thanks for the quick fix and your hard work! Just updated to kmail (4:18.08.3+p18.04+git20181130.0018-0) and can confirm problem is fixed (new and reply). |