Bug 401277

Summary:	More bugs in z13 support
Product:	[Developer tools] valgrind	Reporter:	Andreas Arnez <arnez>
Component:	vex	Assignee:	Julian Seward <jseward>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mark
Priority:	NOR
Version First Reported In:	3.15 SVN
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	More fixes for z13 support

Description Andreas Arnez 2018-11-21 14:20:38 UTC

The following additional problems with the current z13 support were found:

* LOCGHI sign-extends the immediate operand to 32 bits only, should be 64 bits.

* VXRS are not advertised in HWCAP, which may cause problems with a z13-targeted
  glibc.

Comment 1 Andreas Arnez 2018-11-21 14:22:05 UTC

Created attachment 116447 [details]
More fixes for z13 support

This should fix the two problems above.

Comment 2 Mark Wielaard 2018-11-21 22:54:35 UTC

I backported this and the patches for bug #400490 (s390x: Fix register allocation for VRs vs FPRs), bug #400491 (s390x: Sign-extend immediate operand of LOCHI and friends), bug #397187 (s390x: Add vector register support for vgdb) and bug#385411 (s390x: z13 vector floating-point instructions not implemented).

That seems to make valgrind usable on a s390x system build with -march=z13 like http://downloads.redhat.com/redhat/rhel/rhel-8-beta/README

Fedora packages are here:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1166032

Comment 3 Andreas Arnez 2018-11-22 12:48:34 UTC

Got approval from Julian via IRC today.  Pushed as git commit ddfc274b2.