Bug 401234

Summary:	Improve album art display of media players
Product:	[Plasma] plasmashell	Reporter:	trmdi
Component:	Task Manager and Icons-Only Task Manager widgets	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde, mvourlakos, nate, noahadvs, plasma-bugs-null
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	unspecified
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-desktop/e8af68ad76bb329a8bee8aa6f1a82653098eaa9e	Version Fixed/Implemented In:	5.16.0
Sentry Crash Report:

Description trmdi 2018-11-20 06:16:58 UTC

SUMMARY
Please see the screenshot: https://i.imgur.com/FALC3xJ.png
The album art in VLC's tooltip is not displayed fully compared to the real image in VLC.

STEPS TO REPRODUCE
1. open a song that has an embed album art e.g. https://freeallmusic.top/track/7768-1462-1677/109 with VLC (or similar apps)
2. Hover the VLC icon on the panel to show the tooltip

OBSERVED RESULT
The album art is not displayed fully.

EXPECTED RESULT
The preview tooltip should display the album art fully, does not crop it.

Or background of the tooltip's title rectangle "VLC media player/ Dua Lipa - ..." should be transparent.

Comment 1 trmdi 2018-11-20 08:48:00 UTC

*** Bug 401233 has been marked as a duplicate of this bug. ***

Comment 2 Noah Davis 2018-11-20 10:42:37 UTC

I think rather than being cropped, album art should shrink to fit task manager thumbnails. This would also be more consistent with window thumbnail previews.

Comment 3 Nate Graham 2019-03-14 17:43:54 UTC

Git commit e8af68ad76bb329a8bee8aa6f1a82653098eaa9e by Nate Graham, on behalf of Tranter Madi.
Committed on 14/03/2019 at 17:43.
Pushed by ngraham into branch 'master'.

[Task Manager] Do not crop album art in tooltip

Summary:
- The standard aspect ratio of `albumImage` is always `1:1`. We should not crop the important part of `albumArt` in some cases.
- Hide the window title text of media players to avoid displaying the title/artist repeatedly.
FIXED-IN: 5.16.0

Test Plan:
Before vs After:
- Breeze Dark
{F6691504}
- Breeze Light
{F6691505}

Reviewers: hein, broulik, ngraham, #vdg, filipf, rooty

Reviewed By: ngraham, #vdg, filipf, rooty

Subscribers: mvourlakos, rooty, filipf, ndavis, abetts, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D17073

M  +44   -23   applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://commits.kde.org/plasma-desktop/e8af68ad76bb329a8bee8aa6f1a82653098eaa9e