Bug 401171

Summary: Fails to build with flatpak 0.10.4
Product: [Applications] Discover Reporter: Fabian Vogt <fabian>
Component: Flatpak BackendAssignee: Aleix Pol <aleixpol>
Status: RESOLVED FIXED    
Severity: normal CC: jgrulich
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/discover/19130e67b897ac75599d2e73f68a6ef07acabc7b Version Fixed/Implemented In:
Sentry Crash Report:

Description Fabian Vogt 2018-11-18 16:30:49 UTC 
[   77s] -- Checking for module 'flatpak>=0.6.12'
[   77s] --   Found flatpak, version 0.10.4
...
[  122s] In file included from /home/abuild/rpmbuild/BUILD/discover-5.14.80git.20181113T090753~7f6caf38/libdiscover/backends/FlatpakBackend/FlatpakJobTransaction.cpp:25:0:
[  122s] /home/abuild/rpmbuild/BUILD/discover-5.14.80git.20181113T090753~7f6caf38/libdiscover/backends/FlatpakBackend/FlatpakTransactionThread.h:57:5: error: 'FlatpakTransaction' does not name a type; did you mean 'FlatpakJobTransaction'?
[  122s]      FlatpakTransaction* m_transaction;
Comment 1 Aleix Pol 2018-11-19 13:48:32 UTC 
FlatpakTransaction is in libflatpak since 0.6.14. See "git tag --contains 28261d839ec7a373393ba7659fbeacf0e06cc03f".

I'll update the dependency.
Comment 2 Aleix Pol 2018-11-19 13:50:03 UTC 
Git commit 990e8211d2a4ddb6dcd98c42db2729a70a90a180 by Aleix Pol.
Committed on 19/11/2018 at 13:47.
Pushed by apol into branch 'master'.

flatpak: we depend on FlatpakTransaction, so 0.6.14 is needed

M  +1    -1    CMakeLists.txt

https://commits.kde.org/discover/990e8211d2a4ddb6dcd98c42db2729a70a90a180
Comment 3 Aleix Pol 2018-11-19 13:50:17 UTC 
That said, it should be working with 0.10.4, as far as I remember.
Comment 4 Aleix Pol 2018-12-13 04:15:21 UTC 
Can you see that it works now? Or what is the problem exactly?
Is there somewhere I can track it?
Comment 5 Fabian Vogt 2018-12-13 09:18:15 UTC 
(In reply to Aleix Pol from comment #4)
> Can you see that it works now? Or what is the problem exactly?

No, it's still broken the same way.

AFAICT FlatpakTransaction was not public library API until 0.11.8: https://github.com/flatpak/flatpak/commit/516c0f40b6fc4b4d55f125dee443c3809b7e8b8b

> Is there somewhere I can track it?

I'm not sure what you mean - here?
Comment 6 Aleix Pol 2018-12-13 19:02:51 UTC 
My bad, I must have read the logs wrong.

Anyway, we do need 0.11.8, we don't really have a fallback there.
Comment 7 Aleix Pol 2018-12-13 19:03:45 UTC 
Git commit 19130e67b897ac75599d2e73f68a6ef07acabc7b by Aleix Pol.
Committed on 13/12/2018 at 19:01.
Pushed by apol into branch 'master'.

flatpak: Update flatpak dependency version

M  +1    -1    CMakeLists.txt

https://commits.kde.org/discover/19130e67b897ac75599d2e73f68a6ef07acabc7b