Bug 401128

Summary:	KDevelop doesn't back fully to code perspective after commit and unsaved file
Product:	[Applications] kdevelop	Reporter:	Piotr Mierzwinski <piotr.mierzwinski>
Component:	general	Assignee:	kdevelop-bugs-null
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	piotr.mierzwinski
Priority:	NOR
Version First Reported In:	5.3.0
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Piotr Mierzwinski 2018-11-16 23:08:42 UTC

SUMMARY
I needed to commit changes in many files. I reviewed patch file and I modified one file. Forgot save it and just clicked "Commit". Operation has been done. After that I noticed question asking for saving file, so I did it. Unfortunately after this operation KDevelop didn't back fully to "Code" perspective and remained partially in "Review" mode - files opened in "Code" perspective have not been correctly restored (KDevelop opened all changed) only (bottom) "Review"/"Commit" view disappeared. I run commit one more time, for file not saved on first time. This time KDevelop opened it in "Review" mode, I applied commit and KDevelop again remained partially in "Review" mode - files opened in "Code" perspective have not been correctly restored. I had only patch file and this one recently saved.

Additionally buttons showing that some jobs still working were still active, so I clicked "Stop all currently running jobs". Nothing changed. Still I was in the same broken perspective.

I'm not sure how to back fully to "Code" perspective - restore all opened files. I remember that couple versions back there was some switcher on main window, after just disappeared.
I killed KDevelop having hope that I get back my opened files. Unfortunately after KDevelop started run I saw no one files opened.
Really annoying issue.

STEPS TO REPRODUCE
1. Try to commit couple files
2. Modify one of them in "Review patch"/"Commit" mode
3. Click commit
4. Save not saved file
5. Click commit and apply it in Review mode

OBSERVED RESULT
Files opened in "Code" perspective have not been restored. In editor is opened only patch file and file recently commit.

EXPECTED RESULT
Files opened in "Code" perspective should be restored correctly.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: YES
(available in About System)
KDE Plasma Version: 5.14.3
KDE Frameworks Version: 5.52.0
Qt Version: 5.11.2

ADDITIONAL INFORMATION

Comment 1 Piotr Mierzwinski 2018-11-20 22:51:48 UTC

OK. Today I reproduced this issue couple times. Below please find the steps.

STEPS TO REPRODUCE (couple files)
0. Remove directory ~/.local/share/kdevelop and run KDevelop
1. Open some project (C++ for example)
2. Open couple files, for example 5
3. Modify 3 files and save them
4. Use "Show Differences.." for whole project
(click in root item of project and select "Git -> Show Differences..")
In result you will get "Overview" file and all modified files opened
5. Click "Finish Review"

OBSERVED RESULT
In result we will get patch file and all modified files opened.
Unfortunately not modified files didn't back. Where are they?
I don't know possibility to restore all opened previously files.

EXPECTED RESULT
After click "Finish Review" all opened files before use "Git -> Show Differences.." should be restored.

STEPS TO REPRODUCE (one file)
Just continue previous list
6. Use "Show Differences.." for single modified file
(RMB in body of this file and select "Git -> Show Differences..")
7. Click "Finish Review"

OBSERVED RESULT
In result you will get patch file and one modified files opened.
Unfortunately other not compared files have not been opened.
It is easy to restore them, because we can use trick from begin list of steps. Therefore we need to jump to point 4th and in result will get all modified files. Unfortunately not modified files we need opened one more time, manually.

EXPECTED RESULT
After click "Finish Review" all opened files before use "Git -> Show Differences.." should be restored.

I retested KDevelop version: 5.2.4, 5.2.0, 5.1.2 (using AppImage files).
Unfortunately issue happens in all of them.
This is a little bit strange, because I remember that this issue didn't happen in previous versions :-/. After test 5.3.0 version I thought this is regression. Now I'm confused.
BTW. Nightly build of 5.3.0, so KDevelop-git-x86_64.AppImage crashed.

Comment 2 Piotr Mierzwinski 2018-11-22 22:27:27 UTC

Seems this issue is specific only to my system and or KDevelop configuration.
I tried to reproduce in KaOS with KDevelop 5.3.0 and all was working fine.

Comment 3 Piotr Mierzwinski 2018-11-28 23:03:51 UTC

After removed all configuration, so:
.config
  session
  session/kdevelop_1011d10dde79000154275708900000007010041_1543364718_215279
  kdeveloprc
.local/share
  kdevappwizard
  kdevelop
  kdevelop-qthelp
  kdevfiletemplates
  kdevpythonsupport
.local/share/kxmlgui5
  kdevclangsupport
  kdevcodeutils
  kdevcontextbrowser
  kdevcppcheck
  kdevcvs
  kdevdebugger
  kdevdocumentswitcher
  kdevelop
  kdevfiletemplates
  kdevgdb
  kdevgrepview
  kdevheaptrack
  kdevlldb
  kdevpatchreview
  kdevprojectmanagerview
  kdevquickopen
  kdevsession
  kdevsourceformatter
  kdevswitchtobuddy
  kdevvalgrind

KDevelop correctly back to code perspective after commit finished.
Strange was that after very first run of KDevelop, views "Snippets" and "Documentations" were not displayed despite they were turned on in configuration. This looks like a bug.