Bug 401008

Summary: Tab title "Add GTK Theme" truncated
Product: [Applications] systemsettings Reporter: Alexander Potashev <aspotashev>
Component: kcm_gtkAssignee: Aleix Pol <aleixpol>
Status: RESOLVED FIXED    
Severity: normal CC: aleixpol, nate
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=386478
Latest Commit: https://commits.kde.org/kde-gtk-config/e3274dba5fb2739b226d753df532b78ab123cf81 Version Fixed In: 5.18.0
Sentry Crash Report:
Attachments: screenshot

Description Alexander Potashev 2018-11-13 15:28:56 UTC 
SUMMARY
Tab title "Add GTK Theme" truncated.

STEPS TO REPRODUCE
1. Use Russian i18n for Plasma System Settings (didn't test with others).
2. Open the GTK Application Style KCM
3. Click Get New Styles -> Install a local theme...

OBSERVED RESULT
In the dialog the tab name "Добавить тему GTK+" is truncated (Russian translation for "Add GTK Theme"). See screenshot.

EXPECTED RESULT
Should not be truncated, there is enough space.

SOFTWARE/OS VERSIONS
Windows: 
MacOS: 
Linux/KDE Plasma: 5.13.5
(available in About System)
KDE Plasma Version: 5.13.5
KDE Frameworks Version: 5.48.0
Qt Version: 5.11.1

ADDITIONAL INFORMATION
Comment 1 Alexander Potashev 2018-11-13 15:29:17 UTC 
Created attachment 116284 [details]
screenshot
Comment 2 Christoph Feck 2019-03-24 10:33:26 UTC 
This seems intended, UI sets ElideMode to Qt::ElideMiddle, see https://cgit.kde.org/kde-gtk-config.git/tree/src/ui/dialog_installer.ui#n47
Comment 3 Christoph Feck 2019-03-24 10:35:21 UTC 
Reassigning back to clarify comment #2.
Comment 4 Nate Graham 2019-12-02 03:07:22 UTC 
Git commit e3274dba5fb2739b226d753df532b78ab123cf81 by Nate Graham, on behalf of Mikhail Zolotukhin.
Committed on 02/12/2019 at 03:07.
Pushed by ngraham into branch 'master'.

Remove unneeded options in GTK KCM

Summary:
Since font, icons, cursor theme, toolbar style, icons in menus and buttons settings are now in sync with corresponding plasma settings, they shouldn't be in GTK KCM anymore.

Depends on D24743
Related: bug 406740, bug 401123

FIXED-IN: 5.18.0

Test Plan:
Check if nothing breaks in GTK KCM functionality, that is left.

{F7617327}

{F7693105}

Reviewers: #vdg, #plasma, ngraham, nicolasfella

Reviewed By: #vdg, ngraham, nicolasfella

Subscribers: apol, ngraham, broulik, filipf, GB_2, plasma-devel

Tags: #plasma, #vdg

Maniphest Tasks: T10611

Differential Revision: https://phabricator.kde.org/D24744

M  +0    -3    CMakeLists.txt
M  +0    -14   src/abstractappearance.cpp
M  +0    -14   src/abstractappearance.h
M  +0    -23   src/appearancegtk2.cpp
M  +0    -33   src/appearancegtk3.cpp
M  +0    -7    src/appearencegtk.cpp
D  +0    -87   src/cursorthemesmodel.cpp
D  +0    -41   src/cursorthemesmodel.h
M  +0    -79   src/dialog_installer.cpp
M  +0    -14   src/dialog_installer.h
M  +0    -40   src/dialog_uninstaller.cpp
M  +0    -2    src/dialog_uninstaller.h
D  +0    -60   src/fontshelpers.cpp
D  +0    -30   src/fontshelpers.h
M  +2    -152  src/gtkconfigkcmodule.cpp
M  +0    -8    src/gtkconfigkcmodule.h
D  +0    -131  src/iconthemesmodel.cpp
D  +0    -45   src/iconthemesmodel.h
M  +0    -12   src/installer.cpp
M  +0    -7    src/installer.h
M  +0    -3    src/thread.cpp
M  +114  -260  src/ui/dialog_installer.ui
M  +0    -53   src/ui/dialog_uninstaller.ui
M  +121  -419  src/ui/gui.ui
M  +0    -14   tests/configsavetest.cpp

https://commits.kde.org/kde-gtk-config/e3274dba5fb2739b226d753df532b78ab123cf81