Summary: | Decorations get huge after reboot with specific font size | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Mahendra Tallur <mahen> |
Component: | decorations | Assignee: | Vlad Zahorodnii <vlad.zahorodnii> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | nate |
Priority: | NOR | ||
Version: | 5.14.2 | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kwin/80da18a143f1b57751e77f9574212ff60ff14950 | Version Fixed In: | 5.15.0 |
Description
Mahendra Tallur
2018-11-12 20:35:41 UTC
Oops, I mixed sizes up. The SUMMARY should obviously be : "When using the Roboto 11 font as window title font, and rebooting, decorations become and remain huge (as long as one doesn't change the font size then reboot)" Nah, it looks like that's indeed a bug in KDecoration. No one emits fontChanged. Git commit 80da18a143f1b57751e77f9574212ff60ff14950 by Vlad Zagorodniy. Committed on 15/11/2018 at 20:08. Pushed by vladz into branch 'master'. [decorations] Emit DecorationSettings::fontChanged signal Summary: No one emits DecorationSettings::fontChanged signal, so if you change the window title font, then titlebars might look differently after reboot. Currently, there are two places where we can emit that signal: - in KDecoration library itself; - and in KWin. Because we would need to listen for a Plasma specific D-Bus signal, the latter option is preferable. Surprisingly, KWin's implementation of DecorationSettingsPrivate already reacts to refreshFonts D-Bus signal (even though indirectly), so all what we have to do is get the current window title font in SettingsImpl::readSettings, and if it's different from the previous one, emit DecorationSettings::fontChanged signal. FIXED-IN: 5.15.0 Test Plan: * Increased the size of the window title font, titlebars got bigger; * Decreased the font size, titlebars got smaller. Reviewers: #kwin, davidedmundson Reviewed By: #kwin, davidedmundson Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D16908 M +7 -0 decorations/settings.cpp M +4 -0 decorations/settings.h https://commits.kde.org/kwin/80da18a143f1b57751e77f9574212ff60ff14950 Thank you so much for the quick fix, Vlad ! |