Bug 400827

Summary:	[Wayland] ‘Shift’ key doesn’t change 'Move to Trash’ to ‘Delete’ in context menu
Product:	[Plasma] plasmashell	Reporter:	Patrick Silva <bugseforuns>
Component:	Desktop icons & Folder View widget	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde, notuxius, plasma-bugs-null
Priority:	NOR
Version First Reported In:	5.20.90
Target Milestone:	1.0
Platform:	Arch Linux
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Patrick Silva 2018-11-07 23:54:00 UTC

STEPS TO REPRODUCE
1. start Wayland sesion
2. right click on some icon on desktop
3. press shift key

OBSERVED RESULT
'Move to trash" entry does not change to 'Delete' in context menu

EXPECTED RESULT
'Move to trash" entry changes to 'Delete' in context menu

SOFTWARE VERSIONS
Arch Linux
KDE Plasma Version: 5.14.3
KDE Frameworks Version: 5.51
Qt Version: 5.12 beta3

ADDITIONAL INFORMATION
Also reproducible on neon dev unstable.

Comment 1 Alexander Mentyu 2018-11-12 11:38:48 UTC

Can reproduce on Netrunner Rolling unstable, cannot reproduce on:

Operating System: KDE neon Developer Edition
KDE Plasma Version: 5.14.80
Qt Version: 5.11.2
KDE Frameworks Version: 5.52.0
Kernel Version: 4.15.0-36-generic

Comment 2 David Edmundson 2018-11-12 11:42:26 UTC

>'Move to trash" entry does not change to 'Delete' in context menu

This didn't happen on the desktop even on X till Plasma 5.15

Comment 3 Patrick Silva 2018-11-12 11:48:03 UTC

(In reply to David Edmundson from comment #2)
> >'Move to trash" entry does not change to 'Delete' in context menu
> 
> This didn't happen on the desktop even on X till Plasma 5.15

why it works on X11 but it does not on Wayland in plasma 5.14.3?

Comment 4 Alexander Mentyu 2018-11-12 11:52:14 UTC

Sorry can also reproduce it on neon Dev Wayland - and context menu with both Delete and Move to Thrash entries appear after click on desktop when previous desktop context menu is present

Comment 5 David Edmundson 2018-11-12 12:44:27 UTC

Oh, it was backported to 5.14.3. I see

Comment 6 Eike Hein 2018-11-16 08:16:40 UTC

5.14 started showing Delete when you pressed Shift before the click. 5.14.3 started doing it also when you pressed Shift with the menu open. Assuming this both works fine on X11, can someone confirm the problem is truly Wayland-specific?

Comment 7 David Edmundson 2019-01-18 19:31:52 UTC

Some observations:

 - Kwin does send the key
 - Key events do not reach the QEventSpy
 - If plasmashell opens the window as a toplevel, it does get the key

Comment 8 Patrick Silva 2021-04-14 17:18:01 UTC

Fixed on neon unstable. :)

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.21.80
KDE Frameworks Version: 5.82.0
Qt Version: 5.15.2
Graphics Platform: Wayland