Bug 400781

Summary: "Show dependencies..." shows no dependency for DEB package
Product: [Applications] Discover Reporter: Patrick Silva <bugseforuns>
Component: discoverAssignee: Aleix Pol <aleixpol>
Status: RESOLVED FIXED    
Severity: normal CC: nate
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Neon   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: screenshot

Description Patrick Silva 2018-11-07 03:24:50 UTC
Created attachment 116141 [details]
screenshot

STEPS TO REPRODUCE
1. open a DEB package with Discover
2. click "Show dependencies..."
3. 

OBSERVED RESULT
no dependency is listed, see my screenshot please.

EXPECTED RESULT
discover shows the dependencies.

SOFTWARE VERSIONS
KDE neon Developer Edition
KDE Plasma: 5.14.80
Qt: 5.11.2
KDE Frameworks: 5.52.0
Comment 1 Aleix Pol 2018-11-09 18:13:00 UTC
Git commit 12eb98592be8773df8bef693b58baf839599ae2f by Aleix Pol.
Committed on 09/11/2018 at 17:28.
Pushed by apol into branch 'master'.

pk: also fetch details for local files

M  +16   -0    libdiscover/backends/PackageKitBackend/LocalFilePKResource.cpp
M  +2    -0    libdiscover/backends/PackageKitBackend/LocalFilePKResource.h
M  +2    -2    libdiscover/backends/PackageKitBackend/PackageKitResource.cpp
M  +4    -3    libdiscover/backends/PackageKitBackend/PackageKitResource.h

https://commits.kde.org/discover/12eb98592be8773df8bef693b58baf839599ae2f
Comment 2 Patrick Silva 2018-11-27 13:41:03 UTC
bug persists on neon dev unstable despite the fix is mentioned in Nate's blog.

https://pointieststick.wordpress.com/2018/11/11/this-week-in-usability-productivity-part-44/
Comment 3 Nate Graham 2018-11-28 00:32:40 UTC
Can confirm, still not working on git master. You can test with https://www.dropbox.com/download?dl=packages/ubuntu/dropbox_2018.11.08_amd64.deb
Comment 4 Aleix Pol 2018-11-28 09:42:21 UTC
I never claimed it to be fixed.
Actually this is unfixable at the moment, there's no way to extract the local package dependencies.
Comment 5 Nate Graham 2018-11-28 14:57:16 UTC
Then we should not show the "Show dependencies" button at all for local packages.
Comment 6 Aleix Pol 2018-12-13 04:10:50 UTC
Git commit 1fb9be36a38668c73d33186229b13adf78083d40 by Aleix Pol.
Committed on 13/12/2018 at 04:08.
Pushed by apol into branch 'Plasma/5.14'.

pk: Don't the dependencies button if there aren't dependencies

M  +1    -0    libdiscover/backends/PackageKitBackend/qml/DependenciesButton.qml

https://commits.kde.org/discover/1fb9be36a38668c73d33186229b13adf78083d40