| Summary: | Trash - "Delete All Permanently" button not visible | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Nicofo <nicofo> |
| Component: | Albums-Trash | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | metzpinguin |
| Priority: | NOR | ||
| Version First Reported In: | 6.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | 6.0.0 | |
| Sentry Crash Report: | |||
| Attachments: |
Trash buttons - bad layout
deleteMenu.png |
||
And I just see also that "Undo" and "Restore" buttons are centered-aligned while "Delete Permanently" is Left-aligned. Just a detail ... ;) The main problem is that we can not put more buttons next to each other. The view can then no longer collapse and does not fit on small screen resolution. For me with Breze, the font is centered, but have seen that it is left-aligned under Windows. A property of the QToolButton. Maik Mmmh, I understand now... I thought that the little arrow at the right of the buttons bar (in red in my screenshot) was because the buttons bar contained 4 buttons but the last one was not displayed (because lack of space for instance). But I see now that this arrow is related to the third button only (hope it is clear). Then maybe another suggestion: 1. No need to rename "Delete All Permanently" into "Empty Trash" (as this is a sub-button of "Delete Permanently") 2. But then it could be useful add the same sub-button to the second button: "Restore All". Personally I would then be less confused by the little arrow at the right of the buttons bar if there are 2 little arrows. This will be clearer that the little arrow contains sub-button. (well this is just my point of view to try and solve what I find a confusing buttons bar) Note: I'm using Appimage on Fedora - button is not centered (so this is not Windows specific) Git commit 288bd3fb56c524f94a9c3bef698d1b93e20b7957 by Maik Qualmann. Committed on 06/11/2018 at 21:41. Pushed by mqualmann into branch 'master'. use QPushButton with menu M +6 -9 core/app/views/trashview.cpp https://commits.kde.org/digikam/288bd3fb56c524f94a9c3bef698d1b93e20b7957 Let's see how this solution is taken up. As I said, we can not get around a menu. Maik Created attachment 116134 [details]
deleteMenu.png
Screenshot from the new commit.
Maik
Seems good to me ! Thanks for your reactivity ;-) |
Created attachment 116132 [details] Trash buttons - bad layout SUMMARY In the buttons bar of the Trash, "Delete All Permanently" is barely visible (I first thought that option was NOT present !). And this seems independent of the size of the window. See screenshot. Other possible improvements: 1. Rename "Delete All Permanently" into "Empty Trash" ? 2. There is button "Restore": why not also add a "Restore All" button (I don't know if it a good idea to add buttons for usability; this is just an idea...)