Bug 400735

Summary:	dragging sliders on bin effects spams undo history
Product:	[Applications] kdenlive	Reporter:	Adam Spiers <kde-bugs>
Component:	Effects & Transitions	Assignee:	Vincent PINON <vpinon>
Status:	RESOLVED WORKSFORME
Severity:	normal	CC:	fritzibaby, jk.kdedev
Priority:	NOR	Keywords:	junior-jobs
Version:	18.04.3	Flags:	fritzibaby: low_hanging+
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:

Description Adam Spiers 2018-11-06 11:51:14 UTC

SUMMARY

Dragging sliders on bin effects with the mouse spams the undo history with an unnecessary number of "Edit Bin Effect" events.

STEPS TO REPRODUCE
1. View > Undo History should be checked
2. Select a clip in the project bin
3. Click to enable Bin effects in the Properties window
4. Add an effect with a slider to the clip, e.g. Contrast
5. Drag the effect slider

OBSERVED RESULT

Undo History window fills up quickly, with a new "Edit Bin Effect" entry for every new value during the drag.

EXPECTED RESULT

Same behaviour as normal (non-bin) effects, with only a single entry in the undo history.

SOFTWARE VERSIONS

kdenlive version: 18.04.3
KDE Plasma version: 5.12.5
Qt version: 5.9.4

Comment 1 emohr 2018-11-10 13:25:13 UTC

confirmed. Added as a Low_Hanging. Solution could be: only on release the mouse from the slider triggers an undo history entry. Like hit enter after you put in a new value.

Comment 2 Julius Künzel 2021-03-03 00:44:14 UTC

To me it seems that this is fixed. Can you please test with the latest version (20.12.2 at the moment, https://kdenlive.org/en/download/) and close this report if it is not relevant anymore?

Comment 3 Bug Janitor Service 2021-03-18 04:33:49 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 4 Bug Janitor Service 2021-04-02 04:33:41 UTC

This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!