Bug 400594

Summary: "Invalid protocol" when clicking on a tag
Product: [Frameworks and Libraries] frameworks-baloo Reporter: Arjun AK <arjunak234>
Component: TagsAssignee: baloo-bugs-null
Status: RESOLVED NOT A BUG    
Severity: normal CC: arjunak234, elvis.angelaccio, mail, nate, smithjd15
Priority: NOR    
Version: 5.50.0   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/baloo/f4dd3f7bab790734b47a31c70fbb68297d4d3062 Version Fixed In:
Sentry Crash Report:

Description Arjun AK 2018-11-02 16:16:16 UTC 
SUMMARY


STEPS TO REPRODUCE

Go to "tags://" and click on any one of the tags


KDE Frameworks 5.50.0
Qt 5.11.1 (built against 5.11.1)
Comment 1 Julian Steinmann 2018-11-08 20:49:32 UTC 
Can confirm this behavior. Most likely a recent regression, as I remember tags:// working earlier this year.

SYSINFO
KDE neon Developer Edition
KDE-Plasma-Version: 5.14.3
Qt-Version: 5.11.2
KDE-Frameworks-Version: 5.52.0
Comment 2 Jamie Smith 2019-01-22 20:54:19 UTC 
Git commit f4dd3f7bab790734b47a31c70fbb68297d4d3062 by James D. Smith.
Committed on 22/01/2019 at 19:02.
Pushed by smithjd into branch 'master'.

[tags_kio] Disable access with a double slashed url, i.e. "tags://".

M  +5    -0    src/kioslaves/tags/kio_tags.cpp

https://commits.kde.org/baloo/f4dd3f7bab790734b47a31c70fbb68297d4d3062
Comment 3 Nate Graham 2019-02-27 02:15:34 UTC 
If this is NOT A BUG, why did you use the `BUG:` keyword in https://cgit.kde.org/baloo.git/commit/?id=f4dd3f7bab790734b47a31c70fbb68297d4d3062?

That keyword means "this commit fixes such-and-such bug."
Comment 4 Jamie Smith 2019-02-27 04:51:53 UTC 
The bug was referenced in the commit because the commit removed the ability to access the slave with an additional /, preventing manifestation of the reported undefined behaviour. The commit did not solve the undefined behaviour allowing to access the slave with an additional /, therefore the bug is not 'fixed'. The bug is 'not a bug', because of host handling expectations in dolphin, kio and elsewhere, accessing the slave with // causes undefined behaviour.
Comment 5 Nate Graham 2019-02-27 14:41:18 UTC 
BUG: means that a commit fixes the bug. If that wasn't your intention, CCBUG: should have been used instead, to avoid causing confusion. See https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
Comment 6 Jamie Smith 2019-02-28 00:19:07 UTC 
CCBUG: can be used when a single source change won't fix the issue. If the bug is closing anyway, BUG: is appropriate.

This discussion has no place in this ticket. If the issue is not resolved, reopen the bug ticket with an explanation. Don't change the resolved status of bugs you are not involved with without a good reason to do so. The resolver has good reasons for marking a bug a certain way.
Comment 7 Arjun AK 2019-03-06 15:03:56 UTC 
You should add a comment explaining the "6".